Skip to content

[BREAKING] chore(project): remove lumx angularjs #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ storybook
**/style-dictionary
**/*.config.js
packages/site-demo/plugins
packages/lumx-angularjs
packages/lumx-react/jest
packages/lumx-react/src/stories/generated
packages/yo-generators
6 changes: 1 addition & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ We'd love for you to contribute to our source code and to make it even better th

## Getting the source code

To be able to contribute, you will have to use the global LumX package from our [GitHub repository](https://github.com/lumapps/design-system). You won't be able to contribute from the distributed packages `@lumx/<angularjs|react>`, so be sure to clone the repository before starting contributing:
To be able to contribute, you will have to use the global LumX package from our [GitHub repository](https://github.com/lumapps/design-system). You won't be able to contribute from the distributed packages, so be sure to clone the repository before starting contributing:

```bash
git clone git@github.com:lumapps/design-system.git
Expand All @@ -25,10 +25,6 @@ Here are the guidelines we'd like you to follow.
- [Coding rules](#coding-rules)
- [Git commit guidelines](#git-commit-guidelines)

## <a name="code-of-conduct"></a> Code of Conduct

As heavy users of [AngularJS](https://github.com/angular/angular.js) and [React](https://github.com/facebook/react/), we encourage you to read and follow the [AngularJS Code of Conduct](https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md) and the [React Code of Conduct](https://github.com/facebook/react/blob/master/CODE_OF_CONDUCT.md).

## <a name="got-a-question-or-a-problem-"></a> Got a question or a problem?

If you have questions about how to use LumX, please direct these to [StackOverflow](http://stackoverflow.com/questions/tagged/LumX).
Expand Down
17 changes: 4 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,16 @@
# LumApps Design System (LumX)

The first official LumApps Design System for [AngularJS][angularjs] or [React][react] applications.
The first official LumApps Design System for [React][react] applications.
_LumX_ will help you design your applications faster and more easily. You will be able to use LumX with either the LumApps design styleguides or the [Google Material Design specifications][material].

## Quick start

To start to use LumX, you can either:

- Install with Yarn/NPM:

```bash
yarn add @lumx/<angularjs|react>
yarn add @lumx/<icons|react>
# Or
npm install @lumx/<angularjs|react>
npm install @lumx/<icons|react>
```

- Download the latest release for [AngularJS][angularjs-release] or [React][react-release]
- Clone the repository: `git clone https://github.com/lumapps/design-system.git`

## Documentation

LumX's documentation is included in the "demo" directory. The demo/documentation site is built with [Webpack][webpack] and may be run locally.
Expand Down Expand Up @@ -76,7 +69,7 @@ you can build LumX by using:
yarn build
```

This will produce the target build for `@lumx/core`, `@lumx/angularjs`, `@lumx/react` and the demo site.
This will produce the target build for `@lumx/core`, `@lumx/icons`, `@lumx/react` and the demo site.

## How to publish packages

Expand All @@ -103,9 +96,7 @@ Releasing a new version of the lumx packages consists in:

Code and documentation copyright 2019 LumApps. Code released under the [MIT license](LICENSE.md).

[angularjs]: https://angularjs.org/
[react]: https://react.org/
[material]: http://www.google.com/design/spec/material-design/introduction.html
[angularjs-release]: https://www.npmjs.com/package/@lumx/angularjs
[react-release]: https://www.npmjs.com/package/@lumx/react
[webpack]: https://webpack.js.org/
1 change: 0 additions & 1 deletion configs/babel.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module.exports = {
cacheDirectory: true,
plugins: [
['angularjs-annotate', { explicitOnly: true }],
'@babel/plugin-proposal-class-properties',
['@babel/plugin-proposal-private-property-in-object', { 'loose': false }],
['@babel/plugin-proposal-private-methods', { 'loose': false }],
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/eslint-config-lumapps/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ module.exports = {
'plugin:react/recommended',
'plugin:prettier/recommended',
],
globals: {
angular: 'readonly',
},
parser: '@typescript-eslint/parser',
parserOptions: {
sourceType: 'module',
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
"build:site": "yarn workspace lumx-site-demo clean && yarn workspace lumx-site-demo build",
"build:react": "yarn workspace @lumx/react build",
"build:core": "yarn workspace @lumx/core build",
"build:angularjs": "yarn workspace @lumx/angularjs build",
"build:storybook": "yarn workspace @lumx/react build:storybook",
"chromatic": "npx chromatic -b build:storybook",
"clean": "rm -rf packages/*/dist; lerna clean --yes && lerna run --stream clean",
Expand Down
38 changes: 0 additions & 38 deletions packages/lumx-angularjs/README.md

This file was deleted.

73 changes: 0 additions & 73 deletions packages/lumx-angularjs/package.json

This file was deleted.

4 changes: 0 additions & 4 deletions packages/lumx-angularjs/src/components/avatar/avatar.html

This file was deleted.

125 changes: 0 additions & 125 deletions packages/lumx-angularjs/src/components/avatar/avatar_directive.js

This file was deleted.

1 change: 0 additions & 1 deletion packages/lumx-angularjs/src/components/badge/badge.html

This file was deleted.

Loading