Update string representation to use get_username() #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 94.73% 94.87% +0.13%
==========================================
Files 11 11
Lines 266 273 +7
==========================================
+ Hits 252 259 +7
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lucasrcezimbra
requested changes
Oct 9, 2025
lucasrcezimbra
requested changes
Oct 13, 2025
The username field is customizable in Django's AbstractBaseUser, by specifying a custom `USERNAME_FIELD`. This model provides the method `get_username` to retrieve the correct representation for the username. In the current implementation of `APIKey`, the code crashes if `USERNAME_FIELD` is not `username`
I addressed these issues and push a fix. I'm not able to run the tests locally at this time, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lucasrcezimbra The username field is customizable in Django's
AbstractBaseUser, by specifying a customUSERNAME_FIELDthat is different fromusername.AbstractBaseUserprovides the methodget_usernameto retrieve the correct representation for the username.In the current implementation of
APIKey, the code crashes ifusernamedoesn't exist on the user model.