Move dirs to luanti and linux and bsd to xdg #16092
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zughy
added
Maintenance
sfence
reviewed
May 1, 2025
| @@ -544,14 +572,25 @@ bool setSystemPaths() | |||
| if (minetest_user_path && minetest_user_path[0] != '\0') { | |||
| path_user = std::string(minetest_user_path); | |||
| } else { | |||
| // TODO: luanti with migration | |||
| path_user = std::string(getHomeOrFail()) | |||
| + "/Library/Application Support/" | |||
There was a problem hiding this comment.
I think, in the case of moving this directory on macOS, the best approach is probably to start using the sandbox app data directory.
It should be more secure and potentially allow us to distribute Luanti via App Store in the future.
There was a problem hiding this comment.
So, what i need to do?
There was a problem hiding this comment.
You need to use NSHomeDirectory() to get the sandbox path.
com.apple.security.app-sandbox has to be added to plist for macos app (misc/macos/Info.plist.in). Otherwise, NSHomeDirectory() would not work as expected.
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename legacy dirs to luanti
Renames legacy dirs to luanti
Minetest → Luanti rename checklist #15322
Idk
It makes easer dump luanti data on xdg systems
To do
This PR is a Work in Progress.
How to test
Build luanti without RUN_IN_PLACE and check .local/share/luanti on linux or bsd, or "C\Users<user>\AppData\Roaming\Luanti" on windows or /Users//Library/Application Support/luanti on mac and is exists check legacy dir