Skip to content

Conversation

@js6pak
Copy link
Contributor

@js6pak js6pak commented Jul 30, 2025

No description provided.

@ltrzesniewski
Copy link
Owner

ltrzesniewski commented Jul 30, 2025

net35 was released 18 years ago... Are you still really using it?

Fody doesn't support it anymore (support currently starts at net452, even though it should probably be bumped to net472 in that doc), so I'm not sure if I want to support it in InlineIL either. I know there are already several old target frameworks, but I'm not eager to expand that list. Anything related to this would go untested and work only by coincidence.

@ltrzesniewski ltrzesniewski added the enhancement New feature or request label Jul 30, 2025
@js6pak
Copy link
Contributor Author

js6pak commented Jul 30, 2025

I've actually started with the intention of forking and using that, but when I realized no changes other than adding it to the list are necessary, thought might as well send a PR.

net35 was released 18 years ago...

Yes, but the last Unity version that still supported (mono) net35 was released 4 years ago 😅
Which is where this would eventually be used, through MonoMod/MonoMod.Backports#6 by projects like BepInEx which strive to be compatible with ancient games.

Anything related to this would go untested and work only by coincidence.

I'd be more than fine with that!

@ltrzesniewski
Copy link
Owner

thought might as well send a PR.

That was the right thing to do, thanks. 👍

I don't have experience with Unity, but I can merge this if it's useful to you (I'm currently AFK so it will have to wait a few days).

One question though: does Unity use a v3.5 MSBuild, or similar? I hope it doesn't since I think it wouldn't be compatible with Fody (which provides a net472 task for the .NET Framework version). You'd need to use a more recent version to build net35 assemblies.

@js6pak
Copy link
Contributor Author

js6pak commented Jul 31, 2025

One question though: does Unity use a v3.5 MSBuild, or similar?

My use case is Unity game modding, and you generally compile mods outside of Unity using regular dotnet tooling and just load the dll.
But yeah, the Unity editor itself doesn't use MSBuild at all, it invokes roslyn/mcs directly, so you wouldn't be able to use Fody there. Although you could still use libraries that use InlineIL that were compiled outside of Unity.

@ltrzesniewski ltrzesniewski merged commit 9f90aab into ltrzesniewski:master Aug 1, 2025
9 checks passed
@ltrzesniewski ltrzesniewski added this to the v1.10.1 milestone Aug 1, 2025
@ltrzesniewski
Copy link
Owner

ltrzesniewski commented Aug 1, 2025

Released in v1.10.1

Also, I like this PR being #35 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants