repo: removed shell.nix and moved to nix flakes #28
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the shell.nix file and updates documentation to reflect the migration to Nix flakes. Key changes include:
- Removal of shell.nix
- Updated README instructions to use Nix flakes via
nix develop - Added a note for Nix/NixOS users on enabling flakes
Files not reviewed (3)
- .bazelignore: Language not supported
- flake.nix: Language not supported
- shell.nix: Language not supported
Comments suppressed due to low confidence (1)
README.md:16
- [nitpick] Consider renaming 'devShell' to 'development shell' for clarity.
> If you are using Nix or NixOS, ensure you have [flakes enabled][enable-flakes] and enter the devShell via `nix develop`.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the repository's documentation to reflect the migration from using shell.nix to nix flakes.
- Removed instructions referencing shell.nix
- Added guidance for Nix and NixOS users to use nix flakes via a devShell
Files not reviewed (3)
- .bazelignore: Language not supported
- flake.nix: Language not supported
- shell.nix: Language not supported
There was a problem hiding this comment.
Pull Request Overview
This PR removes the old shell.nix file and updates the documentation to instruct users on how to use Nix flakes instead.
- Removed references to shell.nix
- Added a note in the usage section for Nix/NixOS users with instructions to use
nix develop
Files not reviewed (3)
- .bazelignore: Language not supported
- flake.nix: Language not supported
- shell.nix: Language not supported
|
@hzeller now everything seems to work. I should possible document what this PR has now enabled, such as:
What do you think? |
| description = "fpga-assembler"; | ||
|
|
||
| inputs = { | ||
| nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable"; |
There was a problem hiding this comment.
I'd probably fix that to a commit or 24.11 so that we don't create a new flake derivation every day nixos-unstable changes.
There was a problem hiding this comment.
I studied a bit more flakes, as long as the flake.lock doesn't get updated, the channel is pinned.
Line 27 in d8f225f
There was a problem hiding this comment.
I prefer to be explicit.
The lock file is a non-human readable format to be explicit.
So we should put the version in the flake.nix to be human readably explicit.
There was a problem hiding this comment.
Upsie! I'll make a commit that adds a specific revision then!
No description provided.