Skip to content

Commit a91b56c

Browse files
authored
Merge pull request #5 from lppjunior/develop
Remove type verification
2 parents 6afe5df + 3311f54 commit a91b56c

File tree

7 files changed

+8
-63
lines changed

7 files changed

+8
-63
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [1.0.3] - 2020-07-30
11+
### Update
12+
- Remove attribute type verification
13+
1014
## [1.0.2] - 2020-07-30
1115
### Update
1216
- Add Observer parameter validations

dist/patterns.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/patterns.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export * from './src'
1+
export * from './src'

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pattern-js",
3-
"version": "1.0.2",
3+
"version": "1.0.3",
44
"description": "Pattern JS project is a collection of pattern implemented in JS",
55
"private": true,
66
"main": "index.js",

src/pattern/observer/Observer.js

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ class Observer {
44
}
55

66
on (event, callback) {
7-
this.checkParam('callback', callback)
87
this.addEvent(event)
98
this.observer[event].push(callback)
109

@@ -17,30 +16,10 @@ class Observer {
1716
}
1817

1918
addEvent(event) {
20-
this.checkParam('event', event)
2119
if (this.observer[event] === undefined) {
2220
this.observer[event] = []
2321
}
2422
}
25-
26-
checkParam(param, value) {
27-
switch (param) {
28-
case 'event':
29-
if (!(typeof value === 'string' || value instanceof String)) {
30-
throw new Error('Event definition must be a string')
31-
}
32-
break;
33-
34-
case 'callback':
35-
if (!(value && {}.toString.call(value) === '[object Function]')) {
36-
throw new Error('callback definition must be a function')
37-
}
38-
break;
39-
40-
default:
41-
throw new Error('Inexistent parameter')
42-
}
43-
}
4423
}
4524

4625
export default Observer

0 commit comments

Comments
 (0)