Merge pull request #4 from lppjunior/develop

Develop

Author: lppjunior

CHANGELOG.md

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.0.2] - 2020-07-30
+### Update
+- Add Observer parameter validations
+- Add Observer tests
+- Update jest to 100% code coverage
+### Fixbug
+- Fix initialize event on subscribe or emit call
+
 ## [1.0.1] - 2020-07-29
 ### Added
 - Update project import references

dist/patterns.min.js

@@ -1,6 +1,6 @@
 {
   "name": "pattern-js",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Pattern JS project is a collection of pattern implemented in JS",
   "private": true,
   "main": "index.js",
@@ -38,10 +38,10 @@
   "jest": {
     "coverageThreshold": {
       "global": {
-        "branches": 80,
-        "functions": 80,
-        "lines": 80,
-        "statements": 80
+        "branches": 100,
+        "functions": 100,
+        "lines": 100,
+        "statements": 100
       }
     },
     "transform": {

dist/patterns.min.js.map

@@ -4,18 +4,43 @@ class Observer {
   }
 
   on (event, callback) {
-    if (this.observer[event] === undefined) {
-      this.observer[event] = []
-    }
-
+    this.checkParam('callback', callback)
+    this.addEvent(event)
     this.observer[event].push(callback)
 
     return this
   }
 
   emit (event, data) {
+    this.addEvent(event)
     this.observer[event].forEach(callback => callback(data))
   }
+
+  addEvent(event) {
+    this.checkParam('event', event)
+    if (this.observer[event] === undefined) {
+      this.observer[event] = []
+    }
+  }
+
+  checkParam(param, value) {
+    switch (param) {
+      case 'event':
+        if (!(typeof value === 'string' || value instanceof String)) {
+          throw new Error('Event definition must be a string')
+        }
+        break;
+
+        case 'callback':
+          if (!(value && {}.toString.call(value) === '[object Function]')) {
+            throw new Error('callback definition must be a function')
+          }
+          break;
+
+      default:
+        throw new Error('Inexistent parameter')
+    }
+  }
 }
 
 export default Observer