[rescue] Report errors for disallowed configurations #27682
+53
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonychen1251
added a commit
to anthonychen1251/opentitan
that referenced
this pull request
Jul 23, 2025
With lowRISC#27682, DFU rescue can now correctly report disallowed rescue commands, removing the need for device log analysis to determine if a command was rejected in the DFU variant. Signed-off-by: Anthony Chen <antchen@google.com>
There was a problem hiding this comment.
LGTM. Just two minor comments. I've also submitted a PR (#27686) updating the rescue disability test to remove the need for device log analysis to determine if a command was rejected in the DFU variant.
anthonychen1251
added a commit
to anthonychen1251/opentitan
that referenced
this pull request
Jul 23, 2025
With lowRISC#27682, DFU rescue can now correctly report disallowed rescue commands, removing the need for device log analysis to determine if a command was rejected in the DFU variant. Signed-off-by: Anthony Chen <antchen@google.com>
Rework the `validate_mode` function to set flags in the DFU context that represent whether a DFU `DnLoad` or `UpLoad` operation is allowed. Report an error in the download/upload handler when an unsupported operation is attempted. Signed-off-by: Chris Frantz <cfrantz@google.com>
anthonychen1251
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the
validate_modefunction to set flags in the DFU context that represent whether a DFUDnLoadorUpLoadoperation is allowed. Report an error in the download/upload handler when an unsupported operation is attempted.