Skip to content

[crypto] Fixed aes_gcm uninitialized output_len pointer #27672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[crypto] Fixed aes_gcm uninitialized output_len pointer #27672

wants to merge 1 commit into from

Conversation

lucasbaizer2
Copy link

See issue #27634 for details on this bug.

@lucasbaizer2 lucasbaizer2 requested a review from a team as a code owner July 21, 2025 20:31
@lucasbaizer2 lucasbaizer2 requested review from moidx and removed request for a team July 21, 2025 20:31
@lucasbaizer2 lucasbaizer2 mentioned this pull request Jul 21, 2025
Open
@moidx moidx requested a review from nasahlpa July 21, 2025 23:36
@nasahlpa
Copy link
Member

Thank you for fixing this!

Could you please add a “Signed-off-by” line to the commit message, as described here? Then, CI will be able to run.

@lucasbaizer2
[crypto] Fixed aes_gcm uninitialized output_len pointer
34122f6 
Signed-off-by: Lucas Baizer <lucasallenbaizer@gmail.com>
nasahlpa
nasahlpa approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@nasahlpa nasahlpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I've manually run the AES-GCM tests on my end and they pass.

Thanks for also adding the sign-off line. However, CI still fails as it expects a different mail for the sign-off:
image

Closes #27634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasahlpa nasahlpa nasahlpa approved these changes

@moidx moidx Awaiting requested review from moidx moidx is a code owner automatically assigned from lowRISC/ot-c-cpp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasbaizer2 @nasahlpa