[dv,otp_ctrl] Fix some unit test failures #27664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: I created issue #27665 for the surprising way tlul_lc_gate fsm errors are flagged. |
|
@Razer6 @davidschrammel please comment on this or add yourselves as reviewers. |
Razer6
reviewed
Jul 21, 2025
| @@ -1,6 +1,10 @@ | |||
| // Copyright lowRISC contributors (OpenTitan project). | |||
| // Licensed under the Apache License, Version 2.0, see LICENSE for details. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| <% | |||
| buffered_parts = [(i, part) for (i, part) in enumerate(otp_mmap["partitions"]) | |||
There was a problem hiding this comment.
Do we both need the index and the partitions? Down below I think only the indices are used?
Allow scoreboard to wait some cycles for an expected timeout to become an outgoing alert to account for flops on the path. The otp_macro fsm errors are flagged as bus integrity errors, which sounds wrong and perhaps should be fixed to be flagged as fatal_prim_otp_alert. For now I changed the order of checks in task check_sec_cm_fi_resp, in otp_ctrl_common_vseq.sv.tpl. Templetize function sec_cm_fi_ctrl_svas since the buffered partitions depend on per-top config. The function was also incorrect for earlgrey. Signed-off-by: Guillermo Maturana <matute@zerorisc.com>
matutem
force-pushed
the
otp_ctrl_failures
branch
from
1394efd to
3462cd4
Compare
|
@Razer6 could you merge this at your convenience? It seems I have no merge rights. |
| $asserton(0, "tb.dut.gen_partitions[4].gen_buffered.u_part_buf.ScrmblDataKnown_A"); | ||
| $asserton(0, "tb.dut.gen_partitions[5].gen_buffered.u_part_buf.ScrmblDataKnown_A"); | ||
| $asserton(0, "tb.dut.gen_partitions[6].gen_buffered.u_part_buf.ScrmblDataKnown_A"); | ||
| $asserton(0, "tb.dut.gen_partitions[7].gen_lifecycle.u_part_buf.ScrmblDataKnown_A"); |
There was a problem hiding this comment.
Lifecycle is also a buffered partition; so isn't this asserton/assertoff still needed for the LC partition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow scoreboard to wait some cycles for an expected timeout to become an outgoing alert to account for flops on the path.
The otp_macro fsm errors are flagged as bus integrity errors, which sounds wrong and perhaps should be fixed to be flagged as fatal_prim_otp_alert. For now I changed the order of checks in task check_sec_cm_fi_resp, in otp_ctrl_common_vseq.sv.tpl.
Templetize function sec_cm_fi_ctrl_svas since the buffered partitions depend on per-top config. The function was also incorrect for earlgrey.