[keymgr_dpe,rtl] Allow a flop between keymgr_dpe and KMAC #27661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelpi
approved these changes
Jul 18, 2025
|
Please also wait for @davidschrammel 's confirmation that this solves the issues he has been observing before merging. |
This is behind a FlopToKmac parameter and works by inserting a prim_fifo_sync with depth 2. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
keymgr-dpe-kmac-flop
branch
from
ecf7313 to
5b3ae7e
Compare
|
(force push is pretty trivial: it just adds a type that I'd forgotten for the new parameter) |
Razer6
reviewed
Jul 22, 2025
| ''', | ||
| type: "bit", | ||
| default: "0", | ||
| local: "false", |
There was a problem hiding this comment.
@rswarbrick Can you make that a local parameter such that the HJSON is the SSOT and it cannot be overwritten by the instantiation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be useful in Darjeeling, where there's potentially a long path between the keymgr's active key slot and kmac's app input.