Skip to content

[test]: fix early return due to incorrect indent #27649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Elieva
Copy link

@Elieva Elieva commented Jul 17, 2025

Fix indentation of the return statement (was in the outer for-loop, should be outside the for-loop).
The functions resturned after the first test group iteration. Tests from following test groups were not added to test_vectors.

Only 9 tests out of 150 were added to test_vectors.

Fix indentation of the return statement (was in the outer for-loop,
should be outside the for-loop).
The functions resturned after the first test group iteration.
Tests from following test groups were not added to test_vectors.

Only 9 tests out of 150 were added to test_vectors.

Signed-off-by: Elieva Pignat <elievap@google.com>
Copy link
Contributor

@jwnrt jwnrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, thanks

@jwnrt
Copy link
Contributor

jwnrt commented Jul 23, 2025

I think the same might be true for sw/host/cryptotest/testvectors/parsers/wycheproof_rsa_parser.py

@jwnrt jwnrt requested a review from vogelpi July 23, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants