Skip to content

Commit 869a0cc

Browse files
committed
[dv] Remove do_tl_err argument from run_seq_with_rand_reset_vseq
This is set to 1 at all the callsites, so simplify things by getting rid of the unused argument. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
1 parent 7d8ace2 commit 869a0cc

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

hw/dv/sv/cip_lib/seq_lib/cip_base_vseq.sv

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -700,12 +700,11 @@ class cip_base_vseq #(
700700
virtual task rand_reset_eor_clean_up();
701701
endtask
702702

703-
// Run the given sequence and possibly a TL errors vseq (if do_tl_err is set). Suddenly inject a
704-
// reset after at most reset_delay_bound cycles. When we come out of reset, check all CSR values
705-
// to ensure they are the documented reset values.
703+
// Run the given sequence together with a TL errors vseq. Suddenly inject a reset after at most
704+
// reset_delay_bound cycles. When we come out of reset, check all CSR values to ensure they are
705+
// the documented reset values.
706706
virtual task run_seq_with_rand_reset_vseq(uvm_sequence seq,
707707
int num_times = 1,
708-
bit do_tl_err = 1,
709708
uint reset_delay_bound = 10_000_000);
710709
`DV_CHECK_FATAL(seq != null)
711710
`uvm_info(`gfn, $sformatf("running run_seq_with_rand_reset_vseq for sequence %s",
@@ -718,16 +717,14 @@ class cip_base_vseq #(
718717
i, num_times), UVM_LOW)
719718
// Arbitration: requests at highest priority granted in FIFO order, so that we can predict
720719
// results for many non-blocking accesses
721-
if (do_tl_err) p_sequencer.tl_sequencer_h.set_arbitration(UVM_SEQ_ARB_STRICT_FIFO);
720+
p_sequencer.tl_sequencer_h.set_arbitration(UVM_SEQ_ARB_STRICT_FIFO);
722721
fork
723722
begin: isolation_fork
724723
fork : run_test_seqs
725724
begin : seq_wo_reset
726725
fork
727726
begin : tl_err_seq
728-
if (do_tl_err) begin
729-
run_tl_errors_vseq(.num_times($urandom_range(10, 1000)), .do_wait_clk(1'b1));
730-
end
727+
run_tl_errors_vseq(.num_times($urandom_range(10, 1000)), .do_wait_clk(1'b1));
731728
end
732729
begin : run_stress_seq
733730
dv_base_vseq #(RAL_T, CFG_T, COV_T, VIRTUAL_SEQUENCER_T) dv_vseq;
@@ -1037,8 +1034,7 @@ class cip_base_vseq #(
10371034
// injecting a reset. Since the IP block is otherwise quiescent, we only really care about what
10381035
// point in a TL transaction the reset occurs. Each TL transaction takes roughly 10 cycles, so
10391036
// there's no need to wait longer than 1000 cycles (which would be ~100 TL transactions).
1040-
run_seq_with_rand_reset_vseq(.seq(cip_seq), .num_times(num_times), .do_tl_err(1),
1041-
.reset_delay_bound(1000));
1037+
run_seq_with_rand_reset_vseq(.seq(cip_seq), .num_times(num_times), .reset_delay_bound(1000));
10421038
endtask
10431039

10441040
// TLUL mask must be contiguous, e.g. 'b1001, 'b1010 aren't allowed

0 commit comments

Comments
 (0)