fix: Make LootLockerServerAPI use FindObjectsByType instead of tag

Author: Erik Bylund

Runtime/Client/LootLockerServerApi.cs

@@ -8,6 +8,7 @@
 using LootLocker.LootLockerEnums;
 using UnityEditor;
 using LootLocker.Requests;
+using Object = UnityEngine.Object;
 #if UNITY_EDITOR
 using UnityEditorInternal;
 #endif
@@ -26,6 +27,7 @@ public class LootLockerServerApi : MonoBehaviour
         private static int _instanceId = 0;
         private const int MaxRetries = 3;
         private int _tries;
+        public GameObject HostingGameObject = null;
 
         public static void Instantiate()
         {
@@ -37,8 +39,9 @@ public static void Instantiate()
                     gameObject.tag = "LootLockerServerApiGameObject";
                 }
 
-                _instanceId = gameObject.GetInstanceID();
                 _instance = gameObject.AddComponent<LootLockerServerApi>();
+                _instanceId = _instance.GetInstanceID();
+                _instance.HostingGameObject = gameObject;
                 _instance.StartCoroutine(CleanUpOldInstances());
                 if (Application.isPlaying)
                     DontDestroyOnLoad(_instance.gameObject);
@@ -47,17 +50,13 @@ public static void Instantiate()
 
         public static IEnumerator CleanUpOldInstances()
         {
-            if (!_bTaggedGameObjects)
+            LootLockerServerApi[] serverApis = GameObject.FindObjectsByType<LootLockerServerApi>(FindObjectsInactive.Include, FindObjectsSortMode.None);
+            foreach (LootLockerServerApi serverApi in serverApis)
             {
-                yield break;
-            }
-            GameObject[] gameObjects = GameObject.FindGameObjectsWithTag("LootLockerServerApiGameObject");
-            foreach (GameObject gameObject in gameObjects)
-            {
-                if (_instanceId != gameObject.GetInstanceID())
+                if (serverApi != null && _instanceId != serverApi.GetInstanceID() && serverApi.HostingGameObject != null)
                 {
 #if UNITY_EDITOR
-                    DestroyImmediate(gameObject);
+                    DestroyImmediate(serverApi.HostingGameObject);
 #else
                     Destroy(gameObject);
 #endif
@@ -84,20 +83,6 @@ private static void OnEnterPlaymodeInEditor(EnterPlayModeOptions options)
         {
             ResetInstance();
         }
-
-        [InitializeOnLoadMethod]
-        private static void CreateTag()
-        {
-            if (InternalEditorUtility.tags.Contains("LootLockerServerApiGameObject"))
-            {
-                _bTaggedGameObjects = true;
-            }
-            else
-            {
-                InternalEditorUtility.AddTag("LootLockerServerApiGameObject");
-                _bTaggedGameObjects = true;
-            }
-        }
 #endif
 
         public static void SendRequest(LootLockerServerRequest request, Action<LootLockerResponse> OnServerResponse = null)