Skip to content

Add drag start and end events #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add drag start and end events #89

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f469d01
Add drag-started and drag-ended events
scottmadinsonos Mar 24, 2016
976f2ba
Cleanup attr() call
scottmadinsonos Mar 24, 2016
29881a4
factor out event construction
scottmadinsonos Mar 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions js/simple-slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ var __slice = [].slice,
SimpleSlider = (function() {

function SimpleSlider(input, options) {
var ratio,
_this = this;
var _this = this;
this.input = input;
this.defaultOptions = {
animate: true,
Expand Down Expand Up @@ -78,6 +77,7 @@ var __slice = [].slice,
}
_this.dragging = true;
_this.dragger.addClass("dragging");
_this.input.trigger("slider:drag-started", _this._makeEventData());
_this.domDrag(e.pageX, e.pageY);
return false;
});
Expand All @@ -92,6 +92,9 @@ var __slice = [].slice,
if (_this.dragging) {
_this.dragging = false;
_this.dragger.removeClass("dragging");
_this.input.trigger("slider:drag-ended", _this._makeEventData());
// Post final position here
_this.domDrag(e.pageX, e.pageY, false);
return $("body").css({
cursor: "auto"
});
Expand All @@ -105,13 +108,7 @@ var __slice = [].slice,
this.value = this.nearestValidValue(this.input.val());
}
this.setSliderPositionFromValue(this.value);
ratio = this.valueToRatio(this.value);
this.input.trigger("slider:ready", {
value: this.value,
ratio: ratio,
position: ratio * this.slider.outerWidth(),
el: this.slider
});
this.input.trigger("slider:ready", this._makeEventData());
}

SimpleSlider.prototype.createDivElement = function(classname) {
Expand Down Expand Up @@ -292,14 +289,20 @@ var __slice = [].slice,
return;
}
this.value = value;
eventData = {
value: value,
ratio: ratio,
position: ratio * this.slider.outerWidth(),
eventData = this._makeEventData(value, ratio, trigger);
return this.input.val(value).trigger($.Event("change", eventData)).trigger("slider:changed", eventData);
};

SimpleSlider.prototype._makeEventData = function(value, ratio, trigger) {
var v = value || this.value,
r = ratio || this.valueToRatio(v);
return {
value: v,
ratio: r,
position: r * this.slider.outerWidth(),
trigger: trigger,
el: this.slider
};
return this.input.val(value).trigger($.Event("change", eventData)).trigger("slider:changed", eventData);
};

return SimpleSlider;
Expand Down Expand Up @@ -351,7 +354,7 @@ var __slice = [].slice,
if ($el.data("slider-theme")) {
settings.theme = $el.data("slider-theme");
}
if ($el.attr("data-slider-highlight")) {
if ($el.data("slider-highlight")) {
settings.highlight = $el.data("slider-highlight");
}
if ($el.data("slider-animate") != null) {
Expand Down