fix: mark a property generated if it is STORED or VIRTUAL #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaqilniz
force-pushed
the
fix/generated-properties
branch
2 times, most recently
from
7f5c02f to
de1c74f
Compare
dhmlau
reviewed
Dec 4, 2024
| @@ -181,7 +188,14 @@ function mixinDiscovery(MySQL, mysql) { | |||
| ' numeric_scale AS "dataScale",' + | |||
| ' column_type AS "columnType",' + | |||
| ' is_nullable = \'YES\' AS "nullable",' + | |||
| ' CASE WHEN extra LIKE \'%auto_increment%\' THEN 1 ELSE 0 END AS "generated"' + | |||
| ` | |||
| case | |||
There was a problem hiding this comment.
If there's GENERATED ALWAYS when using VIRTUAL or STORED, should we check for that?
Also could you please make the syntax consistent? i.e. for line 193:
WHEN extra LIKE '%virtual%' THEN 1
There was a problem hiding this comment.
@aaqilniz, are you interested to continue to pursue with this PR?
There was a problem hiding this comment.
Hi, @dhmlau. I will update the PR soon and notify you for the review.
There was a problem hiding this comment.
Hi, @dhmlau. I have just made a quick update. Can you please have a look at the PR?
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
fix/generated-properties
branch
from
de1c74f to
0815121
Compare
dhmlau
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machine