feat: generate SDKs for Looker 25.8 #1584

drstrangelooker · 2025-05-19T16:17:59Z

Release-As: 25.8.0

gemini-code-assist

Hello @drstrangelooker, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

I've updated the SDKs across multiple languages (C#, Go, Kotlin, TypeScript/JavaScript, Python, Swift) to align with Looker version 25.8. This release includes the addition of several new API models, primarily focused on validation results for CI runs (Assert, Content, LookML, SQL validators) and parameters for Period Over Period calculations. Additionally, the sync_lookml_dashboard method has been modified to accept an optional list of dashboard IDs to sync, removing the previous body parameter.

Highlights

New API Models: Added new API models to represent results and errors for various validators used in CI runs (Assert, Content, LookML, SQL).
Period Over Period Support: Introduced new models and enums to support Period Over Period calculations within LookML fields.
sync_lookml_dashboard Method Update: The sync_lookml_dashboard method signature has been updated to remove the body parameter and add an optional dashboard_ids parameter, allowing syncing of specific UDD dashboards.
CI Model Enhancements: Existing CI-related models (CIChangeRequest, CIGitState, CIRun, CIRunResult, CIScheduleTrigger) have been updated with more detailed descriptions and structural changes, including changing CIRun.result to a single CIRunResult object.
Dialect Info Updates: Added new properties (default_max_queries, default_max_queries_per_user) to the DialectInfo model and renamed DialectDriverVersion to DialectDriverNamesVersion.
Generic Error Model: Added a new GenericError model for standardized error representation.

Changelog

Click here to see the changelog

csharp/rtl/Constants.cs
- Updated LookerVersion constant to "25.8".
csharp/sdk/4.0/methods.cs
- Modified sync_lookml_dashboard method signature to remove body: WriteDashboard parameter and add optional dashboard_ids: DelimArray<string>? parameter.
- Updated internal call to AuthRequest to pass dashboard_ids in query parameters and null for the body.
csharp/sdk/4.0/models.cs
- Updated comment reflecting increased API model count (353 to 373).
- Added new models: AssertValidatorErrorItem, AssertValidatorResult, AssertValidatorTestedExplore, AssertValidatorTestError, AssertValidatorTestSuccess.
- Updated comments and structure for CIChangeRequest, CIGitState, CIRun, CIRunResult, CIScheduleTrigger.
- Changed CIRun.result from CIRunResult[] to CIRunResult?.
- Added new models: ContentValidatorContentError, ContentValidatorErrorItem, ContentValidatorResult, ContentValidatorTestedExplore.
- Removed user_attributes and webhooks properties from CreateCIRunRequest.
- Renamed DialectDriverVersion struct to DialectDriverNamesVersion.
- Added default_max_queries and default_max_queries_per_user properties to DialectInfo.
- Updated DialectInfo.supported_driver_versions type to DialectDriverNamesVersion[].
- Added new model: GenericError.
- Added new enum: Kind.
- Added period_over_period_params property (LookmlModelExploreFieldPeriodOverPeriodParams?) to LookmlModelExploreField.
- Added new model: LookmlModelExploreFieldPeriodOverPeriodParams.
- Added new enum: Period.
- Added new models: LookMLValidatorError, LookMLValidatorErrorItem, LookMLValidatorResult.
- Added new models: SqlValidatorError, SqlValidatorErrorItem, SqlValidatorResult, SqlValidatorTestedExplore.
go/sdk/v4/methods.go
- Modified SyncLookmlDashboard function signature to accept a RequestSyncLookmlDashboard struct.
- Updated internal call to session.Do to pass dashboard_ids in query parameters and nil for the body.
go/sdk/v4/models.go
- Updated comment reflecting increased API model count (423 to 444).
- Added new models: AssertValidatorErrorItem, AssertValidatorResult, AssertValidatorTestedExplore, AssertValidatorTestError, AssertValidatorTestSuccess.
- Updated comments and structure for CIChangeRequest, CIGitState, CIRun, CIRunResult, CIScheduleTrigger.
- Changed CIRun.Result from []CIRunResult to *CIRunResult.
- Added new models: ContentValidatorContentError, ContentValidatorErrorItem, ContentValidatorResult, ContentValidatorTestedExplore.
- Removed UserAttributes and Webhooks properties from CreateCIRunRequest.
- Renamed DialectDriverVersion struct to DialectDriverNamesVersion.
- Added DefaultMaxQueries and DefaultMaxQueriesPerUser properties to DialectInfo.
- Updated DialectInfo.SupportedDriverVersions type to []DialectDriverNamesVersion.
- Added new model: GenericError.
- Added new enum: Kind.
- Added PeriodOverPeriodParams property (*LookmlModelExploreFieldPeriodOverPeriodParams) to LookmlModelExploreField.
- Added new model: LookmlModelExploreFieldPeriodOverPeriodParams.
- Added new enum: Period.
- Added new models: LookMLValidatorError, LookMLValidatorErrorItem, LookMLValidatorResult.
- Added new models: SqlValidatorError, SqlValidatorErrorItem, SqlValidatorResult, SqlValidatorTestedExplore.
- Added new request type: RequestSyncLookmlDashboard.
kotlin/src/main/com/looker/sdk/4.0/methods.kt
- Modified sync_lookml_dashboard function signature to remove body: WriteDashboard parameter and add optional dashboard_ids: DelimArray<String>? parameter.
- Updated internal call to patch to pass dashboard_ids in query parameters and remove the body.
kotlin/src/main/com/looker/sdk/4.0/models.kt
- Updated comment reflecting increased API model count (353 to 373).
- Added new models: AssertValidatorErrorItem, AssertValidatorResult, AssertValidatorTestedExplore, AssertValidatorTestError, AssertValidatorTestSuccess.
- Updated comments and structure for CIChangeRequest, CIGitState, CIRun, CIRunResult, CIScheduleTrigger.
- Changed CIRun.result from Array<CIRunResult>? to CIRunResult?.
- Added new models: ContentValidatorContentError, ContentValidatorErrorItem, ContentValidatorResult, ContentValidatorTestedExplore.
- Removed target, user_attributes, and webhooks properties from CreateCIRunRequest.
- Renamed DialectDriverVersion data class to DialectDriverNamesVersion.
- Added default_max_queries and default_max_queries_per_user properties to DialectInfo.
- Updated DialectInfo.supported_driver_versions type to Array<DialectDriverNamesVersion>?.
- Added new model: GenericError.
- Added new enum: Kind.
- Added period_over_period_params property (LookmlModelExploreFieldPeriodOverPeriodParams?) to LookmlModelExploreField.
- Added new model: LookmlModelExploreFieldPeriodOverPeriodParams.
- Added new enum: Period.
- Added new models: LookMLValidatorError, LookMLValidatorErrorItem, LookMLValidatorResult.
- Added new models: SqlValidatorError, SqlValidatorErrorItem, SqlValidatorResult, SqlValidatorTestedExplore.
kotlin/src/main/com/looker/sdk/4.0/streams.kt
- Modified sync_lookml_dashboard streaming function signature to remove body: WriteDashboard parameter and add optional dashboard_ids: DelimArray<String>? parameter.
- Updated internal call to patch to pass dashboard_ids in query parameters and remove the body.
kotlin/src/main/com/looker/sdk/Constants.kt
- Updated LOOKER_VERSION constant to "25.8".
package.json
- Added yarn to dependencies.
packages/sdk/src/4.0/funcs.ts
- Added IRequestSyncLookmlDashboard import.
- Modified sync_lookml_dashboard function signature to accept a Partial<IRequestSyncLookmlDashboard> object.
- Updated internal call to patch to pass raw_locale and dashboard_ids from the request object in query parameters and null for the body.
packages/sdk/src/4.0/methods.ts
- Added IRequestSyncLookmlDashboard import.
- Modified sync_lookml_dashboard method signature to accept a Partial<IRequestSyncLookmlDashboard> object.
- Updated internal call to patch to pass raw_locale and dashboard_ids from the request object in query parameters and null for the body.
packages/sdk/src/4.0/methodsInterface.ts
- Added IRequestSyncLookmlDashboard import.
- Updated sync_lookml_dashboard interface signature to accept a Partial<IRequestSyncLookmlDashboard> object.
packages/sdk/src/4.0/models.ts
- Updated comment reflecting increased API model count (424 to 445).
- Added new interfaces: IAssertValidatorErrorItem, IAssertValidatorResult, IAssertValidatorTestedExplore, IAssertValidatorTestError, IAssertValidatorTestSuccess.
- Updated comments and structure for ICIChangeRequest, ICIGitState, ICIRun, ICIRunResult, ICIScheduleTrigger.
- Changed ICIRun.result from ICIRunResult[] | null to ICIRunResult | undefined.
- Added new interfaces: IContentValidatorContentError, IContentValidatorErrorItem, IContentValidatorResult, IContentValidatorTestedExplore.
- Removed target, user_attributes, and webhooks properties from ICreateCIRunRequest.
- Renamed IDialectDriverVersion interface to IDialectDriverNamesVersion.
- Added default_max_queries and default_max_queries_per_user properties to IDialectInfo.
- Updated IDialectInfo.supported_driver_versions type to IDialectDriverNamesVersion[] | null.
- Added new interface: IGenericError.
- Added new enum: Kind.
- Added period_over_period_params property (ILookmlModelExploreFieldPeriodOverPeriodParams | undefined) to ILookmlModelExploreField.
- Added new interface: ILookmlModelExploreFieldPeriodOverPeriodParams.
- Added new enum: Period.
- Added new interfaces: ILookMLValidatorError, ILookMLValidatorErrorItem, ILookMLValidatorResult.
- Added new interfaces: ISqlValidatorError, ISqlValidatorErrorItem, ISqlValidatorResult, ISqlValidatorTestedExplore.
- Added new request interface: IRequestSyncLookmlDashboard.
packages/sdk/src/4.0/streams.ts
- Added IRequestSyncLookmlDashboard import.
- Modified sync_lookml_dashboard streaming method signature to accept a Partial<IRequestSyncLookmlDashboard> object.
- Updated internal call to authStream to pass raw_locale and dashboard_ids from the request object in query parameters and null for the body.
packages/sdk/src/constants.ts
- Updated sdkVersion constant to '25.8'.
python/looker_sdk/sdk/api40/methods.py
- Modified sync_lookml_dashboard function signature to remove body: mdls.WriteDashboard parameter and add optional dashboard_ids: Optional[mdls.DelimSequence[str]] parameter.
- Updated internal call to patch to pass dashboard_ids in query parameters and remove the body.
python/looker_sdk/sdk/api40/models.py
- Updated comment reflecting increased API model count (353 to 373).
- Added new classes: AssertValidatorErrorItem, AssertValidatorResult, AssertValidatorTestedExplore, AssertValidatorTestError, AssertValidatorTestSuccess.
- Updated comments and structure for CIChangeRequest, CIGitState, CIRun, CIRunResult, CIScheduleTrigger.
- Changed CIRun.result from Optional[Sequence["CIRunResult"]] to Optional["CIRunResult"].
- Added new classes: ContentValidatorContentError, ContentValidatorErrorItem, ContentValidatorResult, ContentValidatorTestedExplore.
- Removed target, user_attributes, and webhooks properties from CreateCIRunRequest.
- Renamed DialectDriverVersion class to DialectDriverNamesVersion.
- Added default_max_queries and default_max_queries_per_user properties to DialectInfo.
- Updated DialectInfo.supported_driver_versions type to Optional[Sequence["DialectDriverNamesVersion"]].
- Added new class: GenericError.
- Added new enum: Kind.
- Added period_over_period_params property (Optional["LookmlModelExploreFieldPeriodOverPeriodParams"]) to LookmlModelExploreField.
- Added new class: LookmlModelExploreFieldPeriodOverPeriodParams.
- Added new enum: Period.
- Added new classes: LookMLValidatorError, LookMLValidatorErrorItem, LookMLValidatorResult.
- Added new classes: SqlValidatorError, SqlValidatorErrorItem, SqlValidatorResult, SqlValidatorTestedExplore.
python/looker_sdk/sdk/constants.py
- Updated sdk_version constant to "25.8".
swift/looker/rtl/constants.swift
- Updated lookerVersion constant to "25.8".
swift/looker/sdk/methods.swift
- Modified sync_lookml_dashboard function signature to remove _ body: WriteDashboard parameter and add optional dashboard_ids: DelimArray<String>? parameter.
- Updated internal call to patch to pass dashboard_ids in query parameters and nil for the body.
swift/looker/sdk/models.swift
- Updated comment reflecting increased API model count (353 to 373).
- Added new structs: AssertValidatorErrorItem, AssertValidatorResult, AssertValidatorTestedExplore, AssertValidatorTestError, AssertValidatorTestSuccess.
- Updated comments and structure for CIChangeRequest, CIGitState, CIRun, CIRunResult, CIScheduleTrigger.
- Changed CIRun.result from [CIRunResult]? to CIRunResult?.
- Added new structs: ContentValidatorContentError, ContentValidatorErrorItem, ContentValidatorResult, ContentValidatorTestedExplore.
- Removed target, user_attributes, and webhooks properties from CreateCIRunRequest.
- Renamed DialectDriverVersion struct to DialectDriverNamesVersion.
- Added default_max_queries and default_max_queries_per_user properties to DialectInfo.
- Updated DialectInfo.supported_driver_versions type to [DialectDriverNamesVersion]?.
- Added new struct: GenericError.
- Added new enum: Kind.
- Added period_over_period_params property (LookmlModelExploreFieldPeriodOverPeriodParams?) to LookmlModelExploreField.
- Added new struct: LookmlModelExploreFieldPeriodOverPeriodParams.
- Added new enum: Period.
- Added new structs: LookMLValidatorError, LookMLValidatorErrorItem, LookMLValidatorResult.
- Added new structs: SqlValidatorError, SqlValidatorErrorItem, SqlValidatorResult, SqlValidatorTestedExplore.
swift/looker/sdk/streams.swift
- Modified sync_lookml_dashboard streaming function signature to remove _ body: WriteDashboard parameter and add optional dashboard_ids: DelimArray<String>? parameter.
- Updated internal call to patch to pass dashboard_ids in query parameters and nil for the body.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

SDKs generated,
For Looker twenty-five point eight,
New models appear,
Validation is clear,
Code flows, no longer debated.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the SDKs to support Looker version 25.8. The changes are comprehensive, including version number bumps, the addition of numerous new models and enums primarily related to CI/CD functionalities and various validators (Assert, Content, LookML, SQL), and adjustments to existing methods and models to align with the new API specification.

Key changes include:

Updates to LookerVersion or sdkVersion constants across all relevant SDKs.
Introduction of new models like GenericError, AssertValidatorResult, ContentValidatorResult, LookMLValidatorResult, SqlValidatorResult, and their associated error/item types. This suggests enhanced validation and error reporting capabilities in the API.
Significant modification to the sync_lookml_dashboard method across all SDKs: it no longer accepts a request body and now uses a dashboard_ids query parameter.
The CIRun.result field has been changed from an array/sequence to a single object, with the CIRunResult model itself becoming a container for various specific validator results.
The CreateCIRunRequest model has been simplified by removing several parameters.
Descriptions for many CI/CD related models have been updated for improved clarity.

Overall, the changes appear to be systematically generated and consistent across the different SDKs. One minor packaging concern has been noted.

Summary of Findings

Unconventional yarn dependency: The yarn package manager has been added to the dependencies section in package.json. This is unusual for a library, as it would cause consumers to install yarn as a transitive dependency. It should likely be in devDependencies or removed if not a direct runtime dependency of the SDK.

Merge Readiness

This pull request largely consists of generated SDK updates for Looker 25.8, which seem consistent and well-executed across the various languages. The new models and API method changes reflect an evolution of the Looker API.

However, there is one concern regarding the package.json file where yarn has been added as a direct dependency. This should be reviewed and potentially changed before merging.

Aside from this packaging concern, the SDK generation itself appears to be in good shape. As I am an AI, I am not authorized to approve pull requests. Please ensure this change is reviewed by other maintainers and the package.json issue is addressed before merging.

package.json

github-actions · 2025-05-19T16:22:04Z

Typescript Tests

2 files ±0 56 suites ±0 1m 1s ⏱️ +3s
208 tests ±0 206 ✅ ±0 2 💤 ±0 0 ❌ ±0
444 runs ±0 440 ✅ ±0 4 💤 ±0 0 ❌ ±0

Results for commit 7b26b44. ± Comparison against base commit 382327f.