-
Notifications
You must be signed in to change notification settings - Fork 39
feat: simplify kbench metrics to focus on key performance indicators #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
derekbit
wants to merge
6
commits into
longhorn:main
Choose a base branch
from
derekbit:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7990141
chore(vendor): update dependencies
derekbit 4d5d7bd
chore(dockerfile): update fio and base images
derekbit e0d4c88
chore: update README.md
derekbit fd6f9f3
feat: simplify kbench metrics to focus on key performance indicators
derekbit d3a3d77
feat: update numjobs for bandwidth and iops
derekbit 6134d8e
chore(workflow): add build.yml
derekbit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
name: build | ||
on: | ||
push: | ||
branches: | ||
- master | ||
- v* | ||
tags: | ||
- v* | ||
pull_request: | ||
workflow_dispatch: | ||
jobs: | ||
build: | ||
name: Build binaries | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Build binaries | ||
run: make | ||
|
||
- uses: codecov/codecov-action@v4 | ||
with: | ||
files: ./coverage.out | ||
flags: unittests | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
|
||
- name: Upload binaries | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: binaries_artifact | ||
path: ./bin/* | ||
|
||
build_push_image: | ||
name: Build and push image | ||
runs-on: ubuntu-latest | ||
needs: build | ||
if: ${{ startsWith(github.ref, 'refs/heads/') || startsWith(github.ref, 'refs/tags/') }} | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Download binaries | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: binaries_artifact | ||
path: ./bin/ | ||
|
||
- name: Add executable permission | ||
run: | | ||
chmod +x ./bin/* | ||
- name: Copy bin folder to package | ||
run: | | ||
cp -r ./bin ./package/ | ||
# For multi-platform support | ||
- name: Set up QEMU | ||
uses: docker/setup-qemu-action@v3 | ||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
|
||
- name: Declare branch | ||
run: | | ||
echo "branch=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" >> "$GITHUB_ENV" | ||
- name: Login to Docker Hub | ||
uses: docker/login-action@v3 | ||
with: | ||
username: ${{ secrets.DOCKER_USERNAME }} | ||
password: ${{ secrets.DOCKER_PASSWORD }} | ||
|
||
# longhornio/kbench image | ||
- name: docker-publish | ||
if: ${{ startsWith(github.ref, 'refs/heads/') }} | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: ./ | ||
push: true | ||
platforms: linux/amd64,linux/arm64 | ||
tags: longhornio/kbench:${{ env.branch }}-head | ||
file: package/Dockerfile | ||
|
||
derekbit marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: docker-publish-with-tag | ||
if: ${{ startsWith(github.ref, 'refs/tags/') }} | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: ./ | ||
push: true | ||
platforms: linux/amd64,linux/arm64 | ||
tags: longhornio/kbench:${{ github.ref_name }} | ||
file: package/Dockerfile | ||
|
||
derekbit marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
bs=128K | ||
iodepth=16 | ||
numjobs=4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,9 @@ | ||
[rand-read-bw] | ||
readwrite=randread | ||
include bw-include.fio | ||
include quick-include.fio | ||
|
||
[rand-write-bw] | ||
readwrite=randwrite | ||
include bw-include.fio | ||
include quick-include.fio | ||
|
||
[seq-read-bw] | ||
[seq-read-bandwidth] | ||
readwrite=read | ||
include bw-include.fio | ||
include bandwidth-include.fio | ||
include quick-include.fio | ||
|
||
[seq-write-bw] | ||
[seq-write-bandwidth] | ||
readwrite=write | ||
include bw-include.fio | ||
include bandwidth-include.fio | ||
include quick-include.fio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
[rand-read-bw] | ||
[rand-read-bandwidth] | ||
readwrite=randread | ||
include bw-include.fio | ||
include common-include.fio | ||
include bandwidth-include.fio | ||
include common-include.fio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
[rand-write-bw] | ||
[rand-write-bandwidth] | ||
readwrite=randwrite | ||
include bw-include.fio | ||
include bandwidth-include.fio | ||
include common-include.fio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
[seq-read-bw] | ||
[seq-read-bandwidth] | ||
readwrite=read | ||
include bw-include.fio | ||
include common-include.fio | ||
include bandwidth-include.fio | ||
include common-include.fio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
[seq-write-bw] | ||
[seq-write-bandwidth] | ||
readwrite=write | ||
include bw-include.fio | ||
include bandwidth-include.fio | ||
include common-include.fio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,10 @@ | ||
[rand-read-bw] | ||
readwrite=randread | ||
include bw-include.fio | ||
include common-include.fio | ||
|
||
[rand-write-bw] | ||
readwrite=randwrite | ||
include bw-include.fio | ||
[seq-write-bandwidth] | ||
readwrite=write | ||
include bandwidth-include.fio | ||
include common-include.fio | ||
|
||
[seq-read-bw] | ||
[seq-read-bandwidth] | ||
readwrite=read | ||
include bw-include.fio | ||
include bandwidth-include.fio | ||
include common-include.fio | ||
|
||
[seq-write-bw] | ||
readwrite=write | ||
include bw-include.fio | ||
include common-include.fio |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.