Skip to content

DEV-46445 Grafana X disable recording rules UI and metadata requests #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

DEV-46445 Grafana X disable recording rules UI and metadata requests #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
377a334
Disable load rule groups
copyhold Oct 15, 2024
765c2c9
remove recording rule ui
copyhold Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/grafana-prometheus/src/datasource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,8 +747,10 @@ export class PrometheusDatasource

async loadRules() {
try {
const res = await this.metadataRequest('/api/v1/rules', {}, { showErrorAlert: false });
const groups = res.data?.data?.groups;
// LOGZ.IO GRAFANA CHANGE :: DEV-46445-disable-recording-rules-fetch-in-grafana-10
// const res = await this.metadataRequest('/api/v1/rules', {}, { showErrorAlert: false });
// const groups = res.data?.data?.groups;
const groups = null;

if (groups) {
this.ruleMappings = extractRuleMappingFromGroups(groups);
Expand Down
2 changes: 1 addition & 1 deletion public/app/features/alerting/unified/components/rules/RulesFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ const RulesFilter = ({ onFilterCleared = () => undefined }: RulesFilerProps) =>
onChange={handleAlertStateChange}
/>
</div>
<div>
<div hidden>{ /* LOGZ.IO GRAFANA CHANGE :: disable recording rules filter */ }
<Label>Rule type</Label>
<RadioButtonGroup options={RuleTypeOptions} value={filterState.ruleType} onChange={handleRuleTypeChange} />
</div>
Expand Down
6 changes: 4 additions & 2 deletions public/app/plugins/datasource/prometheus/datasource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,8 +747,10 @@ export class PrometheusDatasource

async loadRules() {
try {
const res = await this.metadataRequest('/api/v1/rules', {}, { showErrorAlert: false });
const groups = res.data?.data?.groups;
// LOGZ.IO GRAFANA CHANGE :: DEV-46445-disable-recording-rules-fetch-in-grafana-10
// const res = await this.metadataRequest('/api/v1/rules', {}, { showErrorAlert: false });
// const groups = res.data?.data?.groups;
const groups = null;

if (groups) {
this.ruleMappings = extractRuleMappingFromGroups(groups);
Expand Down