feat(core): delete token secrets on token storage disabled #7589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should delete all token secrets when token storage is disabled
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/queries/secret.ts | 📈 +793 Bytes |
| packages/core/src/routes/connector/index.ts | 📈 +477 Bytes |
| packages/core/src/routes/sso-connector/index.ts | 📈 +1022 Bytes |
| packages/integration-tests/src/api/sso-connector.ts | 📈 +232 Bytes |
| packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/enterprise-sso.test.ts | 📈 +637 Bytes |
| packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/social.test.ts | 📈 +738 Bytes |
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to delete token secrets when token storage is disabled for social connectors and enterprise SSO connectors. When the enableTokenStorage setting is changed to false, all stored token secrets associated with the connector are automatically removed.
- Adds automatic deletion of token secrets when token storage is disabled
- Implements token storage support validation for OIDC connectors only
- Adds database queries to delete token secrets by connector ID
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/queries/secret.ts | Adds database methods to delete token secrets by social and enterprise SSO connector IDs |
| packages/core/src/routes/connector/index.ts | Implements token secret deletion for social connectors when token storage is disabled |
| packages/core/src/routes/sso-connector/index.ts | Implements token secret deletion for SSO connectors and adds OIDC validation |
| packages/integration-tests/src/api/sso-connector.ts | Adds update method to SSO connector API for testing |
| packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/social.test.ts | Adds integration test for social connector token deletion |
| packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/enterprise-sso.test.ts | Adds integration test for enterprise SSO connector token deletion |
simeng-li
changed the title
wangsijie
approved these changes
Jul 25, 2025
darcyYe
approved these changes
Jul 25, 2025
...es/integration-tests/src/tests/api/experience-api/sign-in-interaction/enterprise-sso.test.ts
Outdated
Show resolved
Hide resolved
packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/social.test.ts
Outdated
Show resolved
Hide resolved
refactor type assertion code
simeng-li
deleted the
simeng-log-11878-delete-users-existing-tokens-after-disabling-token-storage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should delete all token secrets when token storage is disabled.
Testing
test locally integration test case updated
Checklist
.changeset