Skip to content

refactor: simplify password sign-in sample #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

charIeszhao
Copy link
Member

Summary

Project refactor

image

Testing

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@charIeszhao charIeszhao requested a review from simeng-li October 18, 2024 11:52
@charIeszhao charIeszhao force-pushed the charles-log-10256-refactor-sign-in-with-username-and-password branch 10 times, most recently from f1aa29c to df413c1 Compare October 21, 2024 10:37
@charIeszhao charIeszhao force-pushed the charles-log-10256-refactor-sign-in-with-username-and-password branch from df413c1 to 05ed13c Compare October 21, 2024 11:56
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charIeszhao charIeszhao merged commit 1be74c6 into master Oct 23, 2024
2 checks passed
@charIeszhao charIeszhao deleted the charles-log-10256-refactor-sign-in-with-username-and-password branch October 23, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants