feat: add Google One Tap modal #1117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Google One Tap modal to the documentation site by integrating a new configuration fetch and rendering mechanism in the Layout wrapper. Key changes include introducing a zod schema for config validation, caching of the fetched configuration, and updating the Docusaurus configuration to include the Google One Tap script and API base URL custom field.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/theme/Layout/index.tsx | Adds LayoutWrapper component for fetching and rendering Google One Tap modal. |
| package.json | Adds the "zod" dependency used for runtime config validation. |
| docusaurus.config.ts | Injects the Google One Tap client script and adds a custom field for the API base URL. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
src/theme/Layout/index.tsx
Outdated
|
|
||
| setConfig(validatedConfig); | ||
| } catch (error) { | ||
| console.error('Error fetching or validating Google One Tap config:', error); |
There was a problem hiding this comment.
Consider implementing a graceful fallback UI or user notification in case the config fetch fails rather than only logging the error.
Suggested change
| console.error('Error fetching or validating Google One Tap config:', error); | |
| console.error('Error fetching or validating Google One Tap config:', error); | |
| setFetchError(true); |
Copilot uses AI. Check for mistakes.
src/theme/Layout/index.tsx
Outdated
| id="g_id_onload" | ||
| data-client_id={config.clientId} | ||
| // TODO: implement handleCredentialResponse page | ||
| data-callback="handleCredentialResponse" |
There was a problem hiding this comment.
[nitpick] Consider adding documentation or clarifying the TODO for the 'handleCredentialResponse' callback to guide future implementations.
Copilot uses AI. Check for mistakes.
Deploying logto-docs-tutorials with
|
| Latest commit: |
aeacafe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21f8731a.logto-docs-tutorials.pages.dev |
| Branch Preview URL: | https://yemq-add-local-google-one-ta.logto-docs-tutorials.pages.dev |
Deploying logto-docs with
|
| Latest commit: |
aeacafe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2e354ab.logto-docs.pages.dev |
| Branch Preview URL: | https://yemq-add-local-google-one-ta.logto-docs.pages.dev |
darcyYe
force-pushed
the
yemq-add-local-google-one-tap
branch
from
2b9f070 to
1d52165
Compare
darcyYe
force-pushed
the
yemq-add-local-google-one-tap
branch
from
cea2bd3 to
2f1ff0e
Compare
charIeszhao
reviewed
Jul 1, 2025
charIeszhao
approved these changes
Jul 1, 2025
* feat: check auth status on cloud console * refactor: refactor code * fix: fix page * chore: fix content not render bug * chore: resume least changes * refactor: apply try-retry instead of polling * refactor: use google API instead of HTML component * revert: restore pnpm-lock.yaml to base branch version * refactor: apply browser only to GOT and add referrer policy header * refactor: apply thorough CSP * feat: add GOT callback handler (#1166) * feat: add GOT callback handler * fix: fix CSP, refactor GOT credential verifier * chore: test GET verify API * chore: use otp landing page * chore: add frame-ancestor config * chore: pop up fallback mechanism * chore: redirect in-place and try POST * chore: test without CSP headers for CF * chore: test experience google credential * chore: add debug log and check/grant storage access * chore: update console landing page * refactor: remove unnecessary code * feat: only trigger GOT once * chore: remove unused code * refactor: refactor code
darcyYe
force-pushed
the
yemq-add-local-google-one-tap
branch
from
f22a447 to
3ea4b73
Compare
darcyYe
force-pushed
the
yemq-add-local-google-one-tap
branch
from
3ea4b73 to
492e8dc
Compare
charIeszhao
approved these changes
Jul 23, 2025
gao-sun
approved these changes
Jul 23, 2025
darcyYe
force-pushed
the
yemq-add-local-google-one-tap
branch
8 times, most recently
from
c31a207 to
5d674d9
Compare
darcyYe
force-pushed
the
yemq-add-local-google-one-tap
branch
from
5d674d9 to
8102b7d
Compare
darcyYe
force-pushed
the
yemq-add-local-google-one-tap
branch
from
8102b7d to
aeacafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add Google One Tap modal, resolves LOG-11503