[FSTORE-1411-APPEND] On-Demand Transformation Functions #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs introduced from logicalclocks/feature-store-api#1371
** Changes Done **
Updated check while to set
output_column_names
forhopsworks_udf
so that it does not set theoutput_column_names
if it is empty which can be a possibility when the udf is not attached to a feature view or feature group. Output column names can only be generated when udf is known to be On-Demand (attached to feature group) or Model Dependent (attached to feature view).Changed argument name
transformed
intotransform
as per review comments obtained here ([FSTORE-1411] On-Demand Transformations logicalclocks.github.io#397).Updated vector to have variable
_on_demand_feature_vector_col_name
which store the untransformed and on demand features as a list. This is required to genreate pandas and polars dataframe with correct column names aftercompute_on_demand_features
.Added back changes missed during merge from
hopsworks-api
tofeature-store-api
.JIRA Issue: -
Priority for Review: -
Related PRs:
logicalclocks/feature-store-api#1371
https://github.com/logicalclocks/hopsworks-ee/pull/1862
https://github.com/logicalclocks/loadtest/pull/394
How Has This Been Tested?
Checklist For The Assigned Reviewer: