Skip to content

Added windows support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mohammadsaknini
Copy link

Singnal is only partially supported under windows, so i created the timeout function using threads instead of singals which should work on windows as an alternative.

@Mohammadsaknini
Copy link
Author

Mohammadsaknini commented Oct 25, 2024

Tbh its been a while, but i do think it is indeed a typo. Probably forgot to remove it while fiddling around with the code.

@peterasa
Copy link

I've tested the code and it does work on Windows.
There were some further modifications needed on loop.py though, due to a similar timeout construct occuring in it without calling the util.py/timeout function.

Kudos for the fix, it really helped me. Thanks! 👍

@moujtahid21
Copy link

Dear @Mohammadsaknini I applied your changes to util.py and still get this Attribute Error: module 'signal' has no attribute 'SIGALRM'. Did you mean: 'SIGABRT'? whenever I want to test the examples against Popper. I would be thankful for your help!

@Mohammadsaknini
Copy link
Author

Dear @Mohammadsaknini I applied your changes to util.py and still get this Attribute Error: module 'signal' has no attribute 'SIGALRM'. Did you mean: 'SIGABRT'? whenever I want to test the examples against Popper. I would be thankful for your help!

This pull request was created a year ago, and I'm not sure if the codebase is still the same. However, according to Peterasa, there appears to be a similar timeout construct in loop.py, so it might be worth checking that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants