Skip to content

Add RMU #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 9, 2025
Merged

Add RMU #69

merged 11 commits into from
Mar 9, 2025

Conversation

@molereddy
Copy link
Collaborator

@molereddy molereddy commented Mar 9, 2025 •
edited
Loading

What does this PR do?

Adds RMU and corresponding results and documentation

Fixes # (issue)
Addresses RMU feature request #66

  1. Change overwrite=True for evaluation during training
  2. Minor fix to the device of reference model

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Have you gone through the documentation of adding new components?
  • Did you make sure to update the documentation with your changes? Here are the pointers to documentation
    documentation guidelines.

molereddy and others added 11 commits March 1, 2025 09:13
@molereddy
Fix hyperlinks in README (#2)
54d3560 
* testing commit

* Fixes

* cleanup
@Dornavineeth
Fixed DPO command
4c36e4f
@Dornavineeth
download idk
f7a69de
@Dornavineeth
Merge pull request #3 from Dornavineeth/dpo_fix
1bd4411 
Fix tofu_unlearn.sh for IdKDPO method.
@Dornavineeth
Revert "Dpo fix"
332af36
@Dornavineeth
Merge pull request #4 from Dornavineeth/revert-3-dpo_fix
7d6aef3 
Revert "Dpo fix"
@Dornavineeth
download idk data
f468efb
@Dornavineeth
fix dpo experiment config
ca8d503
@Dornavineeth
Merge pull request #5 from Dornavineeth/dpo_fix
dde60d3 
IdkDPO fix
@molereddy
Merge branch 'locuslab:main' into main
6367fb6
@Dornavineeth @molereddy
RMU (#6)
8b073d6 
* IdkDPO script fix in tofu_unlearn.sh (locuslab#65)

* Fix hyperlinks in README
* Download I don't know data in setup_data.py
* Fix tofu_unlearn.sh for IdkDPO

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>

* overwrite=True

* RMU added

* Fix ref model device

* ruff fix

* RMU updated

* Update rmu.py

* Update README.md: add RMU

* Added references and renamed functions

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>
@Dornavineeth Dornavineeth merged commit a897704 into locuslab:main Mar 9, 2025
1 check passed
@ruidazeng
Copy link
Contributor

Screenshot 2025-03-19 at 12 56 27 PM Screenshot 2025-03-19 at 12 56 38 PM

@ruidazeng ruidazeng mentioned this pull request Mar 20, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@molereddy @ruidazeng @Dornavineeth