Skip to content

Conversation

@Dornavineeth
Copy link
Collaborator

@Dornavineeth Dornavineeth commented Mar 2, 2025

What does this PR do?

Fixes # (issue)

  1. Fix tofu_unlearn.sh for IdkDPO
  2. Download I don't know data in setup_data.py
  3. Fix Hyper links in readme

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Have you gone through the documentation of adding new components?
  • Did you make sure to update the documentation with your changes? Here are the pointers to documentation
    documentation guidelines.

molereddy and others added 4 commits March 1, 2025 09:13
@Dornavineeth Dornavineeth linked an issue Mar 2, 2025 that may be closed by this pull request
@Dornavineeth Dornavineeth linked an issue Mar 2, 2025 that may be closed by this pull request
@Dornavineeth Dornavineeth merged commit d11d760 into locuslab:main Mar 2, 2025
1 check passed
molereddy added a commit to Dornavineeth/open-unlearning that referenced this pull request Mar 9, 2025
* IdkDPO script fix in tofu_unlearn.sh (locuslab#65)

* Fix hyperlinks in README
* Download I don't know data in setup_data.py
* Fix tofu_unlearn.sh for IdkDPO

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>

* overwrite=True

* RMU added

* Fix ref model device

* ruff fix

* RMU updated

* Update rmu.py

* Update README.md: add RMU

* Added references and renamed functions

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>
Dornavineeth added a commit that referenced this pull request Mar 9, 2025
* Fix hyperlinks in README (#2)

* testing commit

* Fixes

* cleanup

* Fixed DPO command

* download idk

* Revert "Dpo fix"

* download idk data

* fix dpo experiment config

* RMU (#6)

* IdkDPO script fix in tofu_unlearn.sh (#65)

* Fix hyperlinks in README
* Download I don't know data in setup_data.py
* Fix tofu_unlearn.sh for IdkDPO

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>

* overwrite=True

* RMU added

* Fix ref model device

* ruff fix

* RMU updated

* Update rmu.py

* Update README.md: add RMU

* Added references and renamed functions

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>

---------

Co-authored-by: Dornavineeth <vineethdorna@gmail.com>
Co-authored-by: Vineeth <48151992+Dornavineeth@users.noreply.github.com>
molereddy added a commit that referenced this pull request Apr 25, 2025
* Fix hyperlinks in README (#2)

* testing commit

* Fixes

* cleanup

* Fixed DPO command

* download idk

* Revert "Dpo fix"

* download idk data

* fix dpo experiment config

* RMU (#6)

* IdkDPO script fix in tofu_unlearn.sh (#65)

* Fix hyperlinks in README
* Download I don't know data in setup_data.py
* Fix tofu_unlearn.sh for IdkDPO

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>

* overwrite=True

* RMU added

* Fix ref model device

* ruff fix

* RMU updated

* Update rmu.py

* Update README.md: add RMU

* Added references and renamed functions

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>

* Add structure to contributions, setup leaderboard, update documentation (#8)

* docs: updates, small corrections, re-formats

* modified ruff commands

* modified ruff commands

* CI/CD minor updates

* added contributing + leaderboard

* fix minor spelling misatkes

* docs: bunch of minor updates

* docs fixes

---------

Co-authored-by: molereddy <m.anmolreddy@gmail.com>

* Fix documentation and some miscellaneous things (#13)

* Re-formatting + more badges

* Update and fix docs

* Make error msg accurate

* handle lack of flash-attn flag better

* Document more hydra features

* update example exp configs to match latest supported metrics

* Change HF logo

* Simplify eval exp cfg dump

* testing push workflows

* Add workflow test branch

* update workflow path again

* Reformat badges to fix blue line issue

* Fix div

* revert change to tests build path

* bunch of tokenization related bug-fixes (#14)

* documentation fix

* remove eos only after removing pad tokens + not use model train inside evaluation

* Fix date to handle Llama3.1 repro issues due to tokenizer automatically adding curr date

* ruff fixes

* minor mistake

* warn about and handle weird tokenization cases for small targets

* Ruff fixes

* The assert must hold by definition

* Updating leaderboard.md numbers

* Allow for invalid evaluations which are excluded from averaging

* bug fix

* ruff fixes

---------

Co-authored-by: Dornavineeth <vineethdorna@gmail.com>
Co-authored-by: ma-kjh <ma-kjh@users.noreply.github.com>
Co-authored-by: sun1187 <sun1187@users.noreply.github.com>
Dornavineeth added a commit that referenced this pull request May 22, 2025
* Fix hyperlinks in README (#2)

* testing commit

* Fixes

* cleanup

* Fixed DPO command

* download idk

* Revert "Dpo fix"

* download idk data

* fix dpo experiment config

* RMU (#6)

* IdkDPO script fix in tofu_unlearn.sh (#65)

* Fix hyperlinks in README
* Download I don't know data in setup_data.py
* Fix tofu_unlearn.sh for IdkDPO

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>

* overwrite=True

* RMU added

* Fix ref model device

* ruff fix

* RMU updated

* Update rmu.py

* Update README.md: add RMU

* Added references and renamed functions

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>

* Add structure to contributions, setup leaderboard, update documentation (#8)

* docs: updates, small corrections, re-formats

* modified ruff commands

* modified ruff commands

* CI/CD minor updates

* added contributing + leaderboard

* fix minor spelling misatkes

* docs: bunch of minor updates

* docs fixes

---------

Co-authored-by: molereddy <m.anmolreddy@gmail.com>

* UNDIAL

* UNDIAL2

* UNDIAL3

* Ruff quality formatting changes

* fix config

* fix docs and script

* Update readme

---------

Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>
Co-authored-by: Dornavineeth <vineethdorna@gmail.com>
Co-authored-by: Vineeth <48151992+Dornavineeth@users.noreply.github.com>
Co-authored-by: molereddy <m.anmolreddy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to interpret the TOFU result

2 participants