-
Couldn't load subscription status.
- Fork 104
Add SatImp and WGA methods #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We add the SatImp (ICML2025) method for open-unlearning framework. 5 files are changed.
This is the latest WGA and SatImp methods
|
Can you link to the papers you are implementing? |
|
Sorry I meant in the PR description. It's hard to navigate to these. |
Sorry for the misunderstanding. I guess you mean that I need to modify the top PR description, adding these links so that others can easily find them? Am I correct? Now the PR is: I need to modify to: What does this PR do?This PR introduces the integration of the SatImp and WGA methods. SatImp: arxiv, Github Have you gone through the contributions guide? Yes Are your changes documented? Read documentation guidelines here. Yes |
|
It seems the ruff check tests we have (for code formatting) are failing. Please follow the instructions in
Thank you a lot for contributing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from code formatting, LGTM.
code check failied, fix
made a mistake in utils?
Sorry for the multiple attempts! The reason is the difference between ruff==0.12.0 and ruff==0.6.6, which makes the different format in utils.py! |
|
@Puning97, thank you for adding your methods with clean implementations. Just added minor comments, which shouldn't take much time but can help with implementation consistency throughout the repo. |
This is the new version that required by vineeth, which fits the open-unlearning better
|
@Puning97 Congratulations on your two new method additions to Open-Unlearning 🎉🎉🎉! We look forward to seeing more of your advanced work and contributions to OU. |
Thank you for your valuable contributions too. I look forward to continued collaboration on advanced research in the future. |
What does this PR do?
This PR introduces the integration of the SatImp (ICML2025) and WGA (ICLR2025) methods.
The original papers are:
SatImp: arxiv, Github
WGA: arxiv, Github
Before submitting