-
Couldn't load subscription status.
- Fork 104
bunch of tokenization related bug-fixes #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* testing commit * Fixes * cleanup
Fix tofu_unlearn.sh for IdKDPO method.
Revert "Dpo fix"
IdkDPO fix
* IdkDPO script fix in tofu_unlearn.sh (locuslab#65) * Fix hyperlinks in README * Download I don't know data in setup_data.py * Fix tofu_unlearn.sh for IdkDPO --------- Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com> * overwrite=True * RMU added * Fix ref model device * ruff fix * RMU updated * Update rmu.py * Update README.md: add RMU * Added references and renamed functions --------- Co-authored-by: Anmol Mekala <49127549+molereddy@users.noreply.github.com>
…on (#8) * docs: updates, small corrections, re-formats * modified ruff commands * modified ruff commands * CI/CD minor updates * added contributing + leaderboard * fix minor spelling misatkes * docs: bunch of minor updates * docs fixes --------- Co-authored-by: molereddy <m.anmolreddy@gmail.com>
* Re-formatting + more badges * Update and fix docs * Make error msg accurate * handle lack of flash-attn flag better * Document more hydra features * update example exp configs to match latest supported metrics * Change HF logo * Simplify eval exp cfg dump * testing push workflows * Add workflow test branch * update workflow path again * Reformat badges to fix blue line issue * Fix div * revert change to tests build path
* documentation fix * remove eos only after removing pad tokens + not use model train inside evaluation * Fix date to handle Llama3.1 repro issues due to tokenizer automatically adding curr date * ruff fixes * minor mistake * warn about and handle weird tokenization cases for small targets * Ruff fixes * The assert must hold by definition * Updating leaderboard.md numbers * Allow for invalid evaluations which are excluded from averaging * bug fix * ruff fixes --------- Co-authored-by: Dornavineeth <vineethdorna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves several bugs related to narrow tokenization cases. 2, 3, 4 are interlinked issues and 1 is close to them as well.
tokenwise_logprobsandtokenwise_vocab_logprobsfunctions were inadvertently keeping theeostoken in the label sequence, leading to the model being forced to predicteostoken in the MIA (minK, minK++, gradnorm) and ES/EM metrics.eosanyways, but still the original intention was to never geteosinvolved in these calculations.eos) leading to low ES scores issues (Extraction Strength on knowmem(MUSE) and perturb(TOFU) #100)Nonein such casesNoneon a data point (usually due to tokenization issues), we set the aggregation to filter out such points and only compute on those that have valuestokenwise_logprobsandtokenwise_vocab_logprobsinvolved changing model train mode. This was better handled in the evaluation metric code itself (used only bygradnormMIA attack).Fixes # (issue)
#98
#100
Before submitting