Skip to content

fix(snapshot): Support args with skip_snapshot_verify marker #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gregfurman
Copy link

@gregfurman gregfurman commented Jun 23, 2025

Motivation

Currently, the skip_snapshot_verify marker only accepts paths as **kwargs -- where passing in positional *args end up being skipped and not used.

Changes

  • Check if args are defined, unpack them, and assign skip paths & conditions correctly.

TODO

  • This will potentially cause some tests that otherwise went unsnapshotted to fail in our pipelines. We should trigger a full run with this feature branch and identify failing tests before merging

@gregfurman gregfurman self-assigned this Jun 23, 2025
@gregfurman gregfurman added the bug Something isn't working label Jun 23, 2025
@gregfurman gregfurman requested a review from tiurin June 23, 2025 13:56
@gregfurman gregfurman marked this pull request as ready for review June 23, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant