-
Notifications
You must be signed in to change notification settings - Fork 1
Allow key value based transformers with custom replacement function #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,53 @@ def test_key_value_replacement(self): | |
|
||
assert json.loads(tmp) == expected_key_value_reference | ||
|
||
def test_key_value_replacement_custom_function(self): | ||
input = { | ||
"hello": "world", | ||
"hello2": "again", | ||
"path": {"to": {"anotherkey": "hi", "inside": {"hello": "inside"}}}, | ||
} | ||
|
||
key_value = TransformerUtility.key_value_replacement_function( | ||
"hello", | ||
replacement_function=lambda k, v: f"placeholder({len(v)})", | ||
reference_replacement=False, | ||
) | ||
|
||
expected_key_value = { | ||
"hello": "placeholder(5)", | ||
"hello2": "again", | ||
"path": {"to": {"anotherkey": "hi", "inside": {"hello": "placeholder(6)"}}}, | ||
} | ||
|
||
copied = copy.deepcopy(input) | ||
ctx = TransformContext() | ||
assert key_value.transform(copied, ctx=ctx) == expected_key_value | ||
assert ctx.serialized_replacements == [] | ||
|
||
copied = copy.deepcopy(input) | ||
key_value = TransformerUtility.key_value_replacement_function( | ||
"hello", | ||
replacement_function=lambda k, v: f"placeholder({len(v)})", | ||
reference_replacement=True, | ||
) | ||
# replacement counters are per replacement key, so it will start from 1 again. | ||
expected_key_value_reference = { | ||
"hello": "<placeholder(5):1>", | ||
"hello2": "again", | ||
"path": { | ||
"to": {"anotherkey": "hi", "<placeholder(6):1>": {"hello": "<placeholder(6):1>"}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: test it with another same-length value to see if we get |
||
}, | ||
} | ||
assert key_value.transform(copied, ctx=ctx) == copied | ||
assert len(ctx.serialized_replacements) == 2 | ||
|
||
tmp = json.dumps(copied, default=str) | ||
for sr in ctx.serialized_replacements: | ||
tmp = sr(tmp) | ||
|
||
assert json.loads(tmp) == expected_key_value_reference | ||
|
||
def test_key_value_replacement_with_falsy_value(self): | ||
input = { | ||
"hello": "world", | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: so far I've seen
reference_replacement
as not too intuitive when defaulted toTrue
, especially because it can change anything in the snapshot, including keys. Many times it goes like this: addingkey_value
transformer, see that comparison breaks, setreference_replacement
toFalse
.Maybe we shouldn't set a default at all to this new enhanced function so that with each use the user thinks about whether they need a reference replacement. I see a drawback that the behavior would then differ from existing transformers, but also have an opinion that the default makes more harm than good.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I made a different observation - usually we want to have reference replacements where possible. We just have to avoid reference replacing values in predefined keys - usually this happens if the transformer matches too much, as random data is not usually in our snapshot keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks for sharing!. I do see value in reference replacements by default, just not in keys. This is a separate discussion though, happy to leave current behavior for this transformer. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the key replacement, this is more a side effect than anything else. Happy to work together to fix this in the future!