Skip to content

Fix healthcheck of aws-replicator proxy container #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fix healthcheck of aws-replicator proxy container #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39a62a0
Fix resolving of `localhost.localstack.cloud` on the aws-replicator p…
RobertLucian Jan 23, 2025
028e641
Add comment to explain why the additional host is needed
RobertLucian Jan 23, 2025
a76561f
Add changelog
RobertLucian Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aws-replicator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ If you wish to access the deprecated instructions, they can be found [here](http

## Change Log

* `0.1.24`: Fix healthcheck probe for proxy container
* `0.1.23`: Fix unpinned React.js dependencies preventing webui from loading
* `0.1.22`: Fix auth-related imports that prevent the AWS proxy from starting
* `0.1.20`: Fix logic for proxying S3 requests with `*.s3.amazonaws.com` host header
Expand Down
6 changes: 5 additions & 1 deletion aws-replicator/aws_replicator/client/auth_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,13 +334,17 @@ def start_aws_auth_proxy_in_container(
# create container
container_name = f"{CONTAINER_NAME_PREFIX}{short_uid()}"
image_name = DOCKER_IMAGE_NAME_PRO
# add host mapping for localstack.cloud to localhost to prevent the health check from failing
additional_flags = (
repl_config.PROXY_DOCKER_FLAGS + " --add-host=localhost.localstack.cloud:host-gateway"
)
DOCKER_CLIENT.create_container(
image_name,
name=container_name,
entrypoint="",
command=["bash", "-c", f"touch {CONTAINER_LOG_FILE}; tail -f {CONTAINER_LOG_FILE}"],
ports=ports,
additional_flags=repl_config.PROXY_DOCKER_FLAGS,
additional_flags=additional_flags,
)

# start container in detached mode
Expand Down
2 changes: 1 addition & 1 deletion aws-replicator/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = localstack-extension-aws-replicator
version = 0.1.23
version = 0.1.24
summary = LocalStack AWS Proxy Extension
description = Proxy AWS resources into your LocalStack instance
long_description = file: README.md
Expand Down
Loading