Skip to content

fix: fix broken react script source urls #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

the-wondersmith
Copy link
Contributor

PR fixes the (currently broken) script source URLs for the aws-replicator extension's built-in webui, specifically by pinning them to the correct version.

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks @the-wondersmith for this fix! 🙌

Would you mind bumping the version in setup.cfg, and adding a short note to the Change Log section in README.md? We can then release a new version with these changes right away. 👍 Thanks!

@the-wondersmith
Copy link
Contributor Author

@whummer My pleasure 🙌. Made and pushed the requested changes 😁.

@whummer whummer merged commit 383b298 into localstack:main Jan 18, 2025
@whummer
Copy link
Member

whummer commented Jan 18, 2025

Done @the-wondersmith - version 0.1.23 of the extension has now been published to pypi 👍 . Thanks again

@the-wondersmith the-wondersmith deleted the fix/aws-replicator/unpkg-react-deps branch January 18, 2025 19:53
@the-wondersmith
Copy link
Contributor Author

Done @the-wondersmith - version 0.1.23 of the extension has now been published to pypi 👍 . Thanks again

Absolutely my pleasure 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants