Skip to content

migrate imports from localstack_ext to localstack.pro.core #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Jul 15, 2024

Motivation

After migrating localstack/localstack to implicit namespace packaging with localstack/localstack#11190, we are now moving towards namespace packages for our Pro code, which comes with some necessary adjustments of any imports from Pro: localstack_ext becomes localstack.pro.core.

This PR prepares the adjustment of the imports and should be merged as soon as the first dev package with the new namespace packaging in the localstack_ext distribution is out.

Depends on https://github.com/localstack/localstack-ext/pull/3221.

Changes

  • Adjusts the hidden imports for PyInstaller when building the binary CLI to the new namespace packages in LocalStack Pro.

TODO

@alexrashed alexrashed self-assigned this Jul 15, 2024
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexrashed alexrashed force-pushed the fix-localstack-pro-imports branch from ccf6f0a to 7f2d27e Compare July 17, 2024 13:48
@alexrashed alexrashed force-pushed the fix-localstack-pro-imports branch from ee4cda1 to ff312d4 Compare July 17, 2024 14:39
@alexrashed alexrashed force-pushed the fix-localstack-pro-imports branch from ff312d4 to c296507 Compare July 18, 2024 08:55
@alexrashed alexrashed marked this pull request as ready for review July 18, 2024 11:50
@alexrashed alexrashed merged commit 2e09274 into main Jul 18, 2024
6 checks passed
@alexrashed alexrashed deleted the fix-localstack-pro-imports branch July 18, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants