fix invalid version in homebrew-tap #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
added a commit
to localstack/homebrew-tap
that referenced
this pull request
Jul 1, 2024
Explicitly sets the version in the homebrew tap to avoid issues with homebrew wrongly detection the version "64". This will be fixed for upcoming releases with localstack/localstack-cli#26. This commit updates the version for the current release. Fixes #3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In localstack/homebrew-tap#3 @mcous raised the issue of an invalid version detection for the LocalStack CLI homebrew tap. They also pointed towards a potential source of the issue: Justintime50/homebrew-releaser#39
Thanks a lot for the pointer! This PR addresses this issue by directly setting the version in the homebrew-releaser.
Changes
versionfield to avoid homebrew incorrectly detecting the version Justintime50/homebrew-releaser#39)