-
Notifications
You must be signed in to change notification settings - Fork 129
set pricing tags for all services & features #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1779.surge.sh 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SFN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AppSync, RDS, Neptune 👍
apigateway was not updated and still shows Pro Image
while some is Community
and some is Base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added change requests for Lambda and Pipes to correct and clarify.
@@ -2,13 +2,8 @@ | |||
title: "Lambda" | |||
linkTitle: "Lambda" | |||
description: Get started with Lambda on LocalStack | |||
aliases: | |||
- /references/lambda-executors/ | |||
- /references/lambda-provider-v2/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the broken link in https://github.com/localstack/localstack-ext/pull/4569, but it will still be there in older versions.
@@ -221,7 +216,7 @@ Create a [GitHub issue](https://github.com/localstack/localstack/issues/new/choo | |||
## Lambda Layers (Pro) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HarshCasper Shouldn't "Pro" refer to a new licensed tier?
- /references/lambda-provider-v2/ | ||
- /references/lambda-asf-provider/ | ||
- /references/lambda-v2-provider/ | ||
tags: ["Free"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HarshCasper Where do we summarize the differences between the Free and Paid version?
Such a summary can be based on our internal description of Difference between Free and Paid in the Lambda service page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hola @joe4dev, we have 1 page in docs to describe Licensing Tiers:
https://docs.localstack.cloud/references/licensing/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the link @quetzalliwrites . That clarifies that we are using "paid" as a summary term for our commercial offerings:
All paid tiers include a fixed allocation of:
I meant the difference between Free and Paid for the service Lambda specifically. We are missing a clear overview in our customer-facing docs (see Notion link Difference between Free and Paid).
@@ -2,9 +2,8 @@ | |||
title: "EventBridge Pipes" | |||
linkTitle: "EventBridge Pipes" | |||
description: Get started with EventBridge Pipes on LocalStack | |||
tags: ["Pro image"] | |||
tags: ["Free"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipes is not in the "Free" tier, but remains in the "Pro image". Please update the tag accordingly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "Ultimate" according to https://docs.localstack.cloud/references/licensing/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing @cloutierMat on API Gateway! Good for S3, SNS, APIGW, DMS, EventBridge, Glacier, RDS and thanks again for the clarification on VerifiedPermissions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit too quick 😅
In the set to be improved Feature Coverage page, we're still using the (Pro)
wording as well:
| [**Amplify** (Pro)]({{< ref "amplify" >}}) | [Details 🔍]({{< ref "references/coverage/coverage_amplify" >}}) | | | |
Should we update it too?
In Configuration too, we're also still using the (Pro)
wording:
docs/content/en/references/configuration.md
Line 219 in d7fc6b6
| `ENFORCE_IAM` (pro) | `0` (default)\|`1` | Enable IAM policy evaluation and enforcement. If this is disabled (the default), IAM policies will have no effect to your requests. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, there are still several mentions of (Pro)
in this file (WebSockets API and Custom Domains). What is the wording nowadays to separate between Free and anything paid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs has this page to outline tiers/licensing options:
https://docs.localstack.cloud/references/licensing/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same question :). I think it should be "paid" following the linked docs page by @quetzalliwrites
All paid tiers include a fixed allocation of:
Co-authored-by: Ben Simon Hartung <42031100+bentsku@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kms, transcribe, route53resolver changes LGTM 👍
Just one comment for DMS where we use "enterprise" for auth token which could be removed.
@@ -15,8 +15,7 @@ The supported APIs are available on our [API coverage page](https://docs.localst | |||
|
|||
{{< callout "note">}} | |||
DMS is in a preview state, supporting only [selected use cases](#supported-use-cases). | |||
It is only available as part of the **LocalStack Enterprise** plan, and you need to set the env `ENABLE_DMS=1` in order to activate it. | |||
If you'd like to try it out, please [contact us](https://www.localstack.cloud/demo) to request access. | |||
You need to set the env `ENABLE_DMS=1` in order to activate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export LOCALSTACK_AUTH_TOKEN=<your-auth-token> # this must be a enterprise license token docker-compose up
We can remove this must be a enterprise license token
from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed Athena, EMR, Glue. LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- DynamoDB Streams is missing a tag (Free)
- Could we instead of "Tag" use something more descriptive (e.g. "Available in:")?
No description provided.