Skip to content

Use get_latest_*_metrics.sh scripts from meta repository #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Apr 1, 2025

Motivation

We need the get_latest_*_metrics.sh scripts from different repositories now, so they have been added to the localstack/meta repository.

To avoid having them in multiple locations, we should get them from the meta repository in the docs workflows as well.

Changes

  • Use migrated get_latest_*_metrics.sh scripts from the meta repository

@dfangl dfangl self-assigned this Apr 1, 2025
@dfangl dfangl requested a review from alexrashed April 1, 2025 10:13
Copy link

github-actions bot commented Apr 1, 2025

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1718.surge.sh 🎊

@dfangl
Copy link
Member Author

dfangl commented Apr 1, 2025

New run: https://github.com/localstack/docs/actions/runs/14193057557/job/39761931231 (cancelled it so it does not create a PR, but the download succeeded as expected)

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Thanks for the push to make the scripts reusable and deliberately switching to its usage everywhere! 💯 🧹

@dfangl dfangl merged commit 4f20f79 into main Apr 1, 2025
4 of 5 checks passed
@dfangl dfangl deleted the adjust-script-locations branch April 1, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants