Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

update APIGW docs on custom domain #1440

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 20, 2024

This PR updates the documentation around API Gateway Custom Domains. The feature was not marked as Pro only. Also added a small paragraph showing the use of it.
\cc @thrau

Page preview: https://localstack-docs-preview-pr-1440.surge.sh/user-guide/aws/apigateway/#custom-domain-names-with-api-gateway-pro

@bentsku bentsku requested a review from HarshCasper August 20, 2024 16:31
@bentsku bentsku self-assigned this Aug 20, 2024
@bentsku bentsku requested a review from cloutierMat as a code owner August 20, 2024 16:31
Copy link

github-actions bot commented Aug 20, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1440.surge.sh 🎊

Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mark it as pro on the Feature Coverage page.

https://localstack-docs-preview-pr-1440.surge.sh/user-guide/aws/feature-coverage/

@bentsku
Copy link
Contributor Author

bentsku commented Aug 20, 2024

We should also mark it as pro on the Feature Coverage page.

I've tried to update it, not very easy as those operations are supported in Community, just not "emulated", and it's not easy to make a difference on that page 😬

Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for addressing the comments. We can get to the full support of custom domains in the future.

@HarshCasper HarshCasper merged commit 81b8e5c into main Aug 21, 2024
5 checks passed
@HarshCasper HarshCasper deleted the apigw-custom-domain-pro branch August 21, 2024 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants