Skip to content

fix parity upgrade action by updating CircleCI URL #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Aug 5, 2024

Motivation

We recently had a few changes to our pipelines.
#1342 already adjusted the Parity Update scripts to some of the changes.
Unfortunately, we've overlooked one change: The pipeline in CircleCI in localstack/localstack has been changed such that it is not called main anymore: localstack/localstack#11049 renamed main to full-run and introduced a new acceptance-only-run.

Unfortunately, we haven't realized that this would have to change this here as well.
Now the artifacts of the old pipeline are not available anymore, which is why the run failed: https://github.com/localstack/docs/actions/runs/10242910192

Changes

  • This PR fixes the parity update action by referencing the correct workflow again.

Testing

@alexrashed alexrashed added the bug Something isn't working label Aug 5, 2024
@alexrashed alexrashed requested a review from steffyP August 5, 2024 12:13
@alexrashed alexrashed self-assigned this Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1415.surge.sh 🎊

@alexrashed alexrashed force-pushed the fix-parity-update-action-2 branch from fd1e88c to 35738b6 Compare August 5, 2024 12:19
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping onto it 🙌

@alexrashed alexrashed merged commit f5d8bc5 into main Aug 5, 2024
5 checks passed
@alexrashed alexrashed deleted the fix-parity-update-action-2 branch August 5, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants