Skip to content

Update Parity Coverage Docs #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Update Parity Coverage Docs #1393

merged 1 commit into from
Jul 22, 2024

Conversation

localstack-bot
Copy link
Collaborator

📖 Parity Metrics Docs Update Report 📖

This PR has been automatically generated to update the AWS parity coverage docs.
It aggregates the latest parity coverage test results from our test pipeline on CircleCI as well as from our Pro integration tests.

👷🏽 Handle this PR

The following options describe how to interact with this PR / the auto-update:

✔️ Accept Changes
If the changes are satisfying, just squash-merge the PR and delete the source branch.

🚫 Ignore Changes
If you want to ignore the changes in this PR, just close the PR and do not delete the source branch. The PR will not be opened and a new PR will not be created for as long as the generated code does not change (or the branch is deleted). As soon as there are new changes, a new PR will be created.

✏️ Adapt Changes
Don't do this. The APIs are auto-generated. If you decide that the APIs should look different, you have to change the code-generation.

⏸️ Pause Updates
Remove the cron-schedule trigger of the GitHub Action workflow which creates these PRs. The action can then still be triggered manually, but it will not be executed automatically.

@localstack-bot localstack-bot requested a review from steffyP July 22, 2024 09:27
Copy link

github-actions bot commented Jul 22, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1393.surge.sh 🎊

@HarshCasper HarshCasper merged commit 1200bd2 into main Jul 22, 2024
5 checks passed
@HarshCasper HarshCasper deleted the parity-coverage-auto-updates branch July 22, 2024 17:56
@steffyP
Copy link
Member

steffyP commented Jul 23, 2024

@HarshCasper: didn't that PR undo all the formatting changes from #1382?
E.g. content/en/references/coverage/ here the extra lines were added, and we removed again with this PR content/en/references/coverage/

@HarshCasper
Copy link
Member

@steffyP This was due to a markdownlint rule that we disabled later. To give extra context, when we initially ran markdownlint on the docs, the MD022 rule was applied which enforces the headers to be surrounded by blank lines. We disabled the rule later since it was not working well with some edge cases. For now, it is not an issue but once we introduce the rule back, it should work properly then.

@steffyP
Copy link
Member

steffyP commented Jul 23, 2024

ok, thanks for clarifying 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants