Skip to content

bump version and fix preview url in ephemeral instance tutorial #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024
Merged

bump version and fix preview url in ephemeral instance tutorial #1388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf10b5e
bump version and fix preview url
lukqw Jul 17, 2024
38997c9
update version on finish comment
lukqw Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions content/en/tutorials/ephemeral-application-previews/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ The following step sets up the dependencies and deploys the application preview

```yaml
- name: Deploy Preview
uses: LocalStack/setup-localstack/ephemeral/startup@v0.2.0
uses: LocalStack/setup-localstack/ephemeral/startup@v0.2.2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
localstack-api-key: ${{ secrets.LOCALSTACK_API_KEY }}
Expand All @@ -126,7 +126,7 @@ The following step sets up the dependencies and deploys the application preview
make bootstrap-frontend
make deploy-frontend
distributionId=$(awslocal cloudfront list-distributions | jq -r '.DistributionList.Items[0].Id')
echo "PREVIEW_URL=$AWS_ENDPOINT_URL/cloudfront/$distributionId/" >> $GITHUB_ENV
echo LS_PREVIEW_URL=$AWS_ENDPOINT_URL/cloudfront/$distributionId/ >> $GITHUB_ENV
```

In the provided workflow:
Expand All @@ -140,7 +140,7 @@ To complete the process, the last step attaches the application preview URL to t

```yaml
- name: Finalize PR comment
uses: LocalStack/setup-localstack/finish@v0.2.0
uses: LocalStack/setup-localstack/finish@v0.2.2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
include-preview: true
Expand Down