Skip to content

add example reference to gitlab documentation page #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

tinyg210
Copy link
Contributor

Add link to the tutorial with a demo project in the GitLab CI documentation page

@tinyg210 tinyg210 requested a review from remotesynth July 13, 2024 00:21
@tinyg210 tinyg210 requested a review from lakkeger as a code owner July 13, 2024 00:21
Copy link

github-actions bot commented Jul 13, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1377.surge.sh 🎊

@tinyg210 tinyg210 requested a review from HarshCasper July 13, 2024 00:21
Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a section called as Examples and add the link over there. For reference — https://docs.localstack.cloud/user-guide/aws/lambda/#examples

@tinyg210 tinyg210 requested a review from HarshCasper July 15, 2024 23:53
@tinyg210
Copy link
Contributor Author

I understand the desire to keep the pattern and have an Examples section, but I also want to keep it at the top, where it's visible and easily accessible.

@tinyg210 tinyg210 removed the request for review from HarshCasper July 22, 2024 22:46
@HarshCasper HarshCasper merged commit 3f20745 into main Jul 23, 2024
4 checks passed
@HarshCasper HarshCasper deleted the add_gitlab_example_reference branch July 23, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants