Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

add docs on lakeformation #1369

Merged
merged 2 commits into from
Jul 15, 2024
Merged

add docs on lakeformation #1369

merged 2 commits into from
Jul 15, 2024

Conversation

HarshCasper
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jul 11, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1369.surge.sh 🎊

@HarshCasper HarshCasper requested a review from silv-io July 12, 2024 12:29
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just some minor comments

$ awslocal lakeformation grant-permissions \
--cli-input-json file://check.json
{{</ command >}}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if that is the case here as well, but without setting ENFORCE_IAM, setting permissions is just "cosmetic". So if that is the case here as well, we should maybe hint at that and at the environment variable here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the user guides currently aren't at par with AWS since we skip mentioning the IAM enforcement feature or setting the right permissions. Will revisit this later.

@HarshCasper HarshCasper merged commit 07bb89d into main Jul 15, 2024
3 checks passed
@HarshCasper HarshCasper deleted the lakeformation-docs branch July 15, 2024 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants