Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

iam policy stream tutorial #1363

Merged
merged 11 commits into from
Jul 18, 2024
Merged

iam policy stream tutorial #1363

merged 11 commits into from
Jul 18, 2024

Conversation

HarshCasper
Copy link
Member

@HarshCasper HarshCasper commented Jul 8, 2024

Copy link

github-actions bot commented Jul 8, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1363.surge.sh 🎊

@HarshCasper HarshCasper changed the title scaffold iam policy stream tutorial iam policy stream tutorial Jul 8, 2024
@HarshCasper HarshCasper force-pushed the iam-policy-stream-tutorial branch from 5e80d26 to 5bde26f Compare July 8, 2024 18:02
@HarshCasper HarshCasper requested review from remotesynth and dfangl July 9, 2024 09:12
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved it, so you can merge it right afterwards, but would love to have my comments addressed before merging (they are not big ones though).

Most importantly, we should use either ENFORCE_IAM alone (then the requests will be blocked), or just IAM_SOFT_MODE (you do not need ENFORCE_IAM for this one anymore), to only show the logs in LS, but do not actively block request. Either would be fine for this tutorial, but we should correctly describe it :)

@tinyg210
Copy link
Contributor

I added a banner image to match the other tutorials, if you wanna merge it

@HarshCasper HarshCasper merged commit 7577fd9 into main Jul 18, 2024
3 checks passed
@HarshCasper HarshCasper deleted the iam-policy-stream-tutorial branch July 18, 2024 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants