Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

V3.5 #1313

Merged
merged 14 commits into from
Jun 13, 2024
Merged

V3.5 #1313

merged 14 commits into from
Jun 13, 2024

Conversation

HarshCasper
Copy link
Member

@HarshCasper HarshCasper commented Jun 5, 2024 •
edited
Loading

This PR:

  • Upgrades LocalStack version to 3.5
  • Adds missing CloudFormation resource provider
  • Documents LAMBDA_K8S_INIT_IMAGE
  • Documents known issues with SNS filter operations
  • Adds a callout for EventBridge v2
  • Add docs on DMS RB
  • Update Neptune RB docs

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1313.surge.sh 🎊

bentsku
bentsku reviewed Jun 5, 2024
View reviewed changes
bentsku
bentsku reviewed Jun 6, 2024
View reviewed changes
HarshCasper and others added 2 commits June 10, 2024 12:42
@HarshCasper @bentsku
Update content/en/user-guide/aws/events/index.md
e08f2b1 
Co-authored-by: Ben Simon Hartung <42031100+bentsku@users.noreply.github.com>
@HarshCasper
update neptune rb
c53e47a
steffyP
steffyP reviewed Jun 10, 2024
View reviewed changes
@HarshCasper @steffyP
Update content/en/user-guide/aws/dms/index.md
ba137ab 
Co-authored-by: steffyP <steffyP@users.noreply.github.com>
steffyP
steffyP approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the dms-docs 🙏

bentsku
bentsku approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing the SNS part and adding the limitation! 🙏 SNS part looks great to me!

dfangl
dfangl suggested changes Jun 10, 2024
View reviewed changes
pinzon
pinzon approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cloutierMat
cloutierMat reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to Neptune RB! 🙏

joe4dev
joe4dev reviewed Jun 11, 2024
View reviewed changes
maxhoheiser
maxhoheiser suggested changes Jun 12, 2024
View reviewed changes
joe4dev
joe4dev approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clarifying the config description for LAMBDA_K8S_INIT_IMAGE (Daniel's comment)

dfangl
dfangl approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the init image comment :)

@HarshCasper HarshCasper merged commit 72987dc into main Jun 13, 2024
3 checks passed
@HarshCasper HarshCasper deleted the v3.5 branch June 13, 2024 12:25
@HarshCasper HarshCasper restored the v3.5 branch June 13, 2024 14:22
@HarshCasper HarshCasper deleted the v3.5 branch June 13, 2024 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steffyP steffyP steffyP approved these changes

@joe4dev joe4dev joe4dev approved these changes

@maxhoheiser maxhoheiser maxhoheiser approved these changes

@dfangl dfangl dfangl approved these changes

@pinzon pinzon pinzon approved these changes

@sannya-singal sannya-singal sannya-singal approved these changes

@bentsku bentsku bentsku approved these changes

@cloutierMat cloutierMat cloutierMat approved these changes

@baermat baermat Awaiting requested review from baermat baermat is a code owner

@Morijarti Morijarti Awaiting requested review from Morijarti

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@HarshCasper @steffyP @joe4dev @maxhoheiser @dfangl @pinzon @sannya-singal @bentsku @cloutierMat