Skip to content

prepare coverage docs creation for DMS #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024
Merged

prepare coverage docs creation for DMS #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions data/coverage/service_display_name.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@
"short_name": "",
"api": "https://docs.aws.amazon.com/config/latest/APIReference/Welcome.html"
},
"dms": {
"long_name": "Database Migration Service",
"short_name": "DMS",
"api": "https://docs.aws.amazon.com/dms/latest/APIReference/Welcome.html"
},
"docdb": {
"long_name": "DocumentDB",
"short_name": "",
Expand Down
5 changes: 0 additions & 5 deletions scripts/create_data_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,6 @@ def main(
# we currently have "sqs" + "sqs-query" endpoints because of different protocols
# the resulting coverage should not care about this though
continue
if service_name == "dms":
# we don't officially support dms yet, so we shouldn't show it in the coverage either
# the generated docs is currently also wrong -> as we don't load the provider, we get 5xx errors, which is interpreted
# as the operations being implemented
continue
service = impl_details.setdefault(service_name, {})
service[row["operation"]] = {
"implemented": True if row["is_implemented"] == "True" else False,
Expand Down
Loading