Skip to content

add dms docs #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2024
Merged

add dms docs #1283

merged 3 commits into from
May 24, 2024

Conversation

steffyP
Copy link
Member

@steffyP steffyP commented May 23, 2024

Adding docs for DMS

Left TODO:

Copy link

github-actions bot commented May 23, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1283.surge.sh 🎊

Persistence on LocalStack for DMS is not supported.


### Unsupported Features or Settings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call them Limitations? I am trying to standardize certain headings and this is one of those things.

Copy link
Member Author

@steffyP steffyP May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I called it "Other Limitations" now, as it's already a sub-header of "Limitations".

@steffyP steffyP marked this pull request as ready for review May 24, 2024 11:14
@steffyP steffyP requested a review from HarshCasper May 24, 2024 11:35
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work, this is great, and the sample is awesome 🚀

@HarshCasper HarshCasper merged commit 3ea6fc6 into main May 24, 2024
4 checks passed
@HarshCasper HarshCasper deleted the dms branch May 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants