Skip to content

use CIRCLE_CI_TOKEN to download artifacts #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

steffyP
Copy link
Member

@steffyP steffyP commented May 6, 2024

The parity-docs-update workflow failed as the download of artifacts from CircleCI isn't possible anymore.
Testing this locally revealed an unauthorized-message, e.g.

curl -X 'GET' "https://circleci.com/api/v2/project/github/localstack/localstack/203915/artifacts" -H 'accept: application/json'
{"message":"You must log in first"}%

Leading to the conclusion that the API may require the Circle-Token now to be set in the header.
Initially we found this issue two weeks ago, but it started working again. However, we now see the same error again.

It goes along with a discuss post we found (but there was no response).

TODO

Copy link

github-actions bot commented May 6, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1245.surge.sh 🎊

@steffyP steffyP closed this May 6, 2024
@steffyP steffyP reopened this May 23, 2024
@steffyP steffyP marked this pull request as draft May 23, 2024 14:32
@steffyP steffyP force-pushed the fix-circleci-download branch 3 times, most recently from 2dc57ab to 437e406 Compare May 23, 2024 18:28
@steffyP steffyP force-pushed the fix-circleci-download branch from 437e406 to 2bda684 Compare May 23, 2024 18:30
@steffyP steffyP marked this pull request as ready for review May 23, 2024 18:36
@steffyP steffyP requested a review from alexrashed May 23, 2024 18:36
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this! 💯 It's pretty weird that the API is jumping around with enforcing auth or not...

@steffyP steffyP merged commit 27f0e48 into main May 24, 2024
3 checks passed
@steffyP steffyP deleted the fix-circleci-download branch May 24, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants