Skip to content

Add option to reset last notification time #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

stephen-cox
Copy link
Member

Fixes #122

What does this change?

Adds a debug option to reset last notification time. This helps with debugging sending email notifications.

image

How to test

Enable Review Date and Workflows Notifications modules. Create some content with associated service contacts. Set review date to some time in the past on the content. Run cron - email notifications should be sent. Click 'Reset last run time'. Run cron again - notification emails will be sent again.

@willguv
Copy link
Member

willguv commented May 20, 2025

@stephen-cox love this, will add to the docs when it's ready

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this :) Looks good overall. I have added a minor suggestion.

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I am assuming the test failures are unrelated.

@ekes
Copy link
Member

ekes commented May 27, 2025

Thanks. I am assuming the test failures are unrelated.

Usual PHP8.4, and review js but not touched in this MR.

@finnlewis finnlewis merged commit 2cecb29 into 1.x May 27, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DX: Reset review notification time
5 participants