Remove the unused $build theme page_header #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #289 Remove the old page_header from the $build array of the service status page controller. This was a left over way of adding the page header from BHCC Drupal 8 / Miggle site and was never used in Localgov Drupal. It's presence was causing a Theme hook page_header not found warning in watchdog.
ekes
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Unless @markconroy can think of an adverse effect I say we should get rid of it sooner rather than later. And now is already later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #289
What does this change?
Remove the old page_header from the $build array of the service status page controller. This was a left over way of adding the page header from BHCC Drupal 8 / Miggle site and was never used in Localgov Drupal. It's presence was causing a
Theme hook page_header not foundwarning in watchdog.How to test
Access a service status page eg. On demo content at /adult-health-and-social-care/status
Then check the log and make sure no warning is logged.
How can we measure success?
No more warnings.
Have we considered potential risks?
If someone has this template and is using it, now they won't have the text 'latest services status' added to it.
Note: This template only exists as a hold over on the BHCC site, it is not present at all in Localgov Drupal.
Images
n/a.
Accessibility
n/a.