Skip to content

2.1.13 release #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2024
Merged

2.1.13 release #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afc6822
Added return docstring for EntityChildRelationshipUi::referencedChild…
stephen-cox Aug 9, 2024
3f046a9
Use EntityReferenceFieldCreationTrait rather than the deprecated Enti…
stephen-cox Aug 9, 2024
69275d3
Merge pull request #274 from localgovdrupal/fix/2.x/273-phpstan-failures
finnlewis Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/localgov_services_navigation/src/EntityChildRelationshipUi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ protected function childrenField(NodeInterface $node) {
*
* @param \Drupal\node\NodeInterface $node
* The `localgov_service_landing` or `localgov_service_sublanding`.
*
* @return array
* Array of node IDs.
*/
public static function referencedChildren(NodeInterface $node) {
$linked = [];
Expand Down
7 changes: 2 additions & 5 deletions ...ces_navigation/tests/src/FunctionalJavascript/EntityReferenceServicesAutocompleteTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
use Drupal\node\NodeInterface;
use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;

Expand All @@ -16,10 +16,7 @@
class EntityReferenceServicesAutocompleteTest extends WebDriverTestBase {

use ContentTypeCreationTrait;
// FIXME: Replace with EntityReferenceFieldCreationTrait when Drupal 10.1 is
// end of life.
// @phpstan-ignore-next-line.
use EntityReferenceTestTrait;
use EntityReferenceFieldCreationTrait;
use NodeCreationTrait;

/**
Expand Down
7 changes: 2 additions & 5 deletions modules/localgov_services_navigation/tests/src/Kernel/ChildReferencesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Drupal\node\NodeInterface;
use Drupal\paragraphs\Entity\Paragraph;
use Drupal\taxonomy\Entity\Term;
use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\Tests\pathauto\Functional\PathautoTestHelperTrait;
Expand All @@ -24,10 +24,7 @@
class ChildReferencesTest extends KernelTestBase {

use ContentTypeCreationTrait;
// FIXME: Replace with EntityReferenceFieldCreationTrait when Drupal 10.1 is
// end of life.
// @phpstan-ignore-next-line.
use EntityReferenceTestTrait;
use EntityReferenceFieldCreationTrait;
use NodeCreationTrait;
use PathautoTestHelperTrait;

Expand Down
7 changes: 2 additions & 5 deletions modules/localgov_services_navigation/tests/src/Kernel/ParentFieldPathautoTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Drupal\KernelTests\KernelTestBase;
use Drupal\language\Entity\ConfigurableLanguage;
use Drupal\node\NodeInterface;
use Drupal\Tests\field\Traits\EntityReferenceTestTrait;
use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\Tests\pathauto\Functional\PathautoTestHelperTrait;
Expand All @@ -18,10 +18,7 @@
class ParentFieldPathautoTest extends KernelTestBase {

use ContentTypeCreationTrait;
// FIXME: Replace with EntityReferenceFieldCreationTrait when Drupal 10.1 is
// end of life.
// @phpstan-ignore-next-line.
use EntityReferenceTestTrait;
use EntityReferenceFieldCreationTrait;
use NodeCreationTrait;
use PathautoTestHelperTrait;

Expand Down